fix(ci): pre-clone nargo external git deps with retry to survive DNS flakes#23263
Closed
AztecBot wants to merge 1 commit into
Closed
fix(ci): pre-clone nargo external git deps with retry to survive DNS flakes#23263AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #23253 (the merge-train/spartan train PR) was dequeued from the merge queue on commit
b5431aa3e4(run 25829983065). Theaztec-nrshard failed becausenargocouldn't clonenoir-lang/sha256@v0.3.0:With
parallel --halt now,fail=1inci.shand 10 grind shards inmerge-queue-heavy, one shard's DNS hiccup kills the entire run. Same flavour as the recent CRS HTTP fix (#23244) — no code regression, just a transient network blip.nargoclones git deps on-demand and has no retry.noir-projects/bootstrap.sh prepalready warms the cache withnargo fmt --check, but the top-levelMakefileinvokes each sub-bootstrap (aztec-nr/,noir-contracts/,noir-protocol-circuits/) in parallel directly, bypassing that prep.What
New
noir-projects/scripts/prefetch_nargo_git_deps.sh:Nargo.tomlundernoir-projects/, extracts(owner/repo, tag)git dep pairs.git clone --depth 1 --branch <tag>into$NARGO_HOME/github.com/<owner>/<repo>/<tag>/, up to 3 attempts with 2s/4s backoff, cleaning partial state between attempts.flockmakes it safe under concurrent calls from parallel make targets; idempotent re-runs are sub-50ms no-ops.Wired into the start of
buildinaztec-nr,noir-contracts,noir-protocol-circuitsbootstraps (coversmock-protocol-circuitstoo, which delegates to noir-protocol-circuits), and intonoir-projects/bootstrap.sh prepfor symmetry.Verification
Locally:
$NARGO_HOMElock-arbitrate correctly.A full
./bootstrap.sh cirun takes hours and the underlying flake is not reproducible on demand, so local verification is structural rather than behavioural. CI will exercise the change on real worker nodes.Detailed analysis: https://gist.github.com/AztecBot/c0c66726b060de2dc986318121bc0f11
ClaudeBox log: https://claudebox.work/s/a27c0434cc7008b9?run=1