fix(bb): push missing q_5 in QArith3Gate test to unbreak nightly debug build#23266
Closed
AztecBot wants to merge 1 commit into
Closed
fix(bb): push missing q_5 in QArith3Gate test to unbreak nightly debug build#23266AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Contributor
|
Handled here #23229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly Barretenberg debug build failed again on
nextthis morning — same root cause as run 25781836067 yesterday. TheUltraCircuitBuilderArithmetic.QArith3Gatetest incircuit_checker_teststrips a debug-only assertion:The assertion fires inside
UltraCircuitBuilder_::check_selector_length_consistency(stdlib_circuit_builders/ultra_circuit_builder.hpp), which is gated by#if NDEBUG ... #elseand so only runs in debug builds — that is why no other CI mode caught it.QArith3Gatebuilds two arithmetic gates manually by pushing each selector individually. Every in-tree gate constructor (create_arithmetic_gate,fix_witness,create_add_gate, etc.) followsq_4().emplace_back(...)withq_5().emplace_back(0); this test was the only manual-construction site that omitted theq_5push.Pre-merge-train, the consistency check used a per-flavour curated
get_selectors()forUltraTraceArithmeticBlockthat did not includeq_5, so the omission was invisible. PR #23137 (feat: merge-train/barretenberg, landed 2026-05-12) refactoredExecutionTraceBlocksoget_selectors()returnsnon_gate_selectors(7 entries includingq_5) concatenated withgate_selectors, expanding the consistency check to coverq_5. The test has been silently broken w.r.t. the new check ever since that landed.What
Add the missing
builder.blocks.arithmetic.q_5().emplace_back(0)to both manually-constructed gates inQArith3Gate, matching the existing convention.Relationship to #23229
#23229 is the same fix, opened yesterday against
merge-train/barretenbergper the barretenberg PR guidelines. It has not merged yet (~24h later), so the cron fired again on the unchangednextHEAD and triggered another ClaudeBox dispatch. This PR is a duplicate targetingnextdirectly so the nightly is unblocked while the merge-train PR proceeds normally. Whichever lands first resolves the recurrence; the second becomes a no-op merge.Verification
Carried over from yesterday's reproduce on the byte-identical patch (session
3064b2e43c917621):Full
circuit_checker_tests(79 tests) plus a sanity-run ofpolynomials_tests,common_tests,relations_testsall pass after the fix. I did not re-run the debug build in this session — the patch is byte-identical to what was verified againstnextyesterday, and the affected file has not changed.Full analysis: https://gist.github.com/AztecBot/cf1bfc054a8a570d9663b89d53dcf810
ClaudeBox log: https://claudebox.work/s/bd69ed5ede2fd589?run=1
ClaudeBox log: https://claudebox.work/s/bd69ed5ede2fd589?run=1