feat: slash for invalid checkpoint proposals#23270
Merged
Merged
Conversation
PhilWindle
reviewed
May 14, 2026
Collaborator
PhilWindle
left a comment
PhilWindle
left a comment
There was a problem hiding this comment.
This LGTM, are you adding an e2e test in a follow up PR?
alexghr
force-pushed
the
ag/slash-invalid-proposal
branch
from
c64d22e to
f2547dc
Compare
Contributor
Author
I'll fold it into the e2e test from #23250 |
alexghr
force-pushed
the
ag/a-626
branch
5 times, most recently
from
c8ce063 to
baa2936
Compare
ludamad
force-pushed
the
merge-train/spartan
branch
from
4af2626 to
db4ec58
Compare
ludamad
requested review from
IlyasRidhuan,
LHerskind,
Maddiaa0,
MirandaWood,
jeanmon and
just-mitch
as code owners
PhilWindle
approved these changes
May 18, 2026
alexghr
force-pushed
the
ag/a-626
branch
3 times, most recently
from
18c8402 to
434b92b
Compare
alexghr
pushed a commit
that referenced
this pull request
May 18, 2026
CI on PR #23270 fails two test cases in `validator-client/src/validator.test.ts`: ``` ValidatorClient › validateBlockProposal › does not emit checkpoint proposal slash event for last_block_archive_mismatch ValidatorClient › validateBlockProposal › does not emit checkpoint proposal slash event for checkpoint_validation_failed ``` `SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT` in `validator.ts` marks `last_block_archive_mismatch` and `checkpoint_validation_failed` as slashable (with an explicit comment that these "late mismatches" indicate the proposer-signed payload disagrees with deterministic recomputation), but the test's "does not emit" parametrized list still included them. Move both reasons from the "does not emit" list into the existing "emits checkpoint proposal slash event for %s" list so the test agrees with the implementation. Merge this PR into `ag/a-626`. --- *Created by [claudebox](https://claudebox.work/v2/sessions/2d2b7e81407ef95f) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix A-626