fix(docs): retry forge build to handle transient solc download DNS failures#23345
Closed
AztecBot wants to merge 1 commit into
Closed
fix(docs): retry forge build to handle transient solc download DNS failures#23345AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing in favor of #23346, which addresses the same DNS-retry issue but:
merge-train/spartan(the train where the CI failure surfaced) instead ofnext.ci3/retryhelper (3 attempts × 5s sleep ≈ 10s total backoff) rather than an inline 5-attempt 5→80s loop, per Santiago's feedback to cap retries under 30s.run_stepvia an$OUTPUT_DIR/.failedmarker — the previous bug was not just "first attempt failed" but that the loop kept going and the function returned 0 even when no artifacts were written.Original CI failure log: http://ci.aztec-labs.com/bc425a95fd076f0d