refactor: use composeConfigMappings throughout codebase#23364
Open
spypsy wants to merge 10 commits into
Open
Conversation
spypsy
force-pushed
the
spy/use-composeConfigMappings
branch
from
9ca2640 to
126fdff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes A-987
Refactors all config modules to use
composeConfigMappingsinstead of object spread (...mappings), and introducesOwnXxxConfigsplit types to clearly separate each component's own fields from inherited shared config.Also does some config utility cleanup: splits
parse_env.tsout ofindex.ts, addsfield_config.tsfor field-specific helpers, and addsparse_env.test.ts.