test: mark e2e_partial_notes as flaky under pipelining#23365
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
merge-train/spartanfailed on commitfe4792ba22(PR #23329) withe2e_partial_notesfailing asTransaction 0x1e7fd673… was dropped. Reason: Tx dropped by P2P node. CI3 log: http://ci.aztec-labs.com/1779100391339924The failure is a pre-existing race in the pipelined sequencer's
waitForValidParentCheckpointOnL1check: when the L1 propose tx for the parent checkpoint hasn't mined yet by the time the pipelined child's parent-landed check runs, the pipelined work is discarded, the next slot has nothing to publish (propose_action_not_successful), and pending txs are dropped duringhandlePrunedBlocks. This is unrelated to anything in PR #23329 — its only non-test diff is an error-handling tweak insidesimulatePublicCalls(the RPC simulate path).Adding a narrow flake entry keyed on the
Tx dropped by P2P nodeerror so the train can advance, with @santiagopalladino as owner since he owns the pipelining work.Full analysis (timeline, log refs, comparison with surrounding train commits, root-cause notes for the publish-race): https://gist.github.com/AztecBot/431b9a3fdeb7e23797fa589f7f6a3431
Recommend adding
ci-skipand force-merging via the bypass-merge button so the merge train can move pastfe4792ba22.ClaudeBox log: https://claudebox.work/s/78410c5e31df03fc?run=1