fix(e2e): deflake duplicate_proposal_slash by targeting offense type directly#23370
Draft
AztecBot wants to merge 1 commit into
Draft
fix(e2e): deflake duplicate_proposal_slash by targeting offense type directly#23370AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing test on merge-train/fairies CI (run 26031248895, log http://ci.aztec-labs.com/1779103559110764):
The merge-train/fairies branch only differs from
nextby three unrelated shell-script files (bootstrap.sh,spartan/scripts/install_deps.sh,yarn-project/aztec/scripts/add_crate.sh), so the failure is a flake.The test previously did two sequential waits:
awaitOffenseDetected— wait up to 16 slots for any offense onhonestNode1.retryUntil— wait an additional 4 slots for aDUPLICATE_PROPOSALoffense across all nodes.If a non-duplicate offense surfaces first on
honestNode1, step (1) returns immediately and step (2) gets only 4 slots (96s) to find the duplicate-proposal entry. If the slasher's offenses-collector hasn't flushed it through within that window, the retry times out even though the duplicate eventually appears.This collapses the two-stage wait into a single
retryUntilthat targetsDUPLICATE_PROPOSALdirectly with the full combined budget (20 slots), removing the race.Investigation gist: https://gist.github.com/AztecBot/d6767ac7756f40cfc9e52157c8664ca1
ClaudeBox log: https://claudebox.work/s/a9d0c3aa5622d671?run=1