fix: align checkpoint slash test list with SLASHABLE map#23372
Merged
Conversation
alexghr
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on PR #23270 fails two test cases in
validator-client/src/validator.test.ts:SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULTinvalidator.tsmarkslast_block_archive_mismatchandcheckpoint_validation_failedas slashable (with an explicit comment that these "late mismatches" indicate the proposer-signed payload disagrees with deterministic recomputation), but the test's "does not emit" parametrized list still included them.Move both reasons from the "does not emit" list into the existing "emits checkpoint proposal slash event for %s" list so the test agrees with the implementation.
Merge this PR into
ag/a-626.Created by claudebox · group:
slackbot