fix(release-image): stamp aztec_version in published contract artifacts#23462
Closed
benesjan wants to merge 2 commits into
Closed
fix(release-image): stamp aztec_version in published contract artifacts#23462benesjan wants to merge 2 commits into
benesjan wants to merge 2 commits into
Conversation
The v4.3.0 release shipped contract artifact JSONs with aztec_version: "dev" baked in, because release-image/Dockerfile copies pre-built artifacts from an earlier stage where REF_NAME isn't set (so stamp_aztec_version in noir-projects/noir-contracts/bootstrap.sh falls back to "dev"). Mirror the stdlib/package.json stamp pattern (75fd494) to re-stamp aztec_version in every artifact under accounts/, noir-contracts.js/, and noir-test-contracts.js/ at image-build time. Also bypass the compat e2e assertContractArtifactsVersion() check narrowly for expected === "4.3.0" && aztecVersion === "dev" so the compat job stops failing against the already-published broken 4.3.0 artifacts. Other versions still fail loudly if they ever report "dev". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
benesjan
added
the
ci-release-pr
AztecBot
removed
the
ci-release-pr
benesjan
commented
May 21, 2026
| // TODO(F-557): Remove once v4.3.0 drops off the compat matrix. The v4.3.0 release shipped with | ||
| // aztec_version: "dev" baked into the published artifact JSONs because release-image/Dockerfile | ||
| // did not re-stamp them. Fixed for future releases by the artifact restamp step in that Dockerfile. | ||
| if (expected === '4.3.0' && aztecVersion === DEV_VERSION) { |
Contributor
Author
There was a problem hiding this comment.
"dev" got already stamped into artifacts from "4.3.0" so this is here to disable this check on the next run. This is fine as this was only a sanity check.
benesjan
added
the
ci-release-pr
Contributor
Author
|
Closed in favor of #23470 to be able to re-trigger the release of the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v4.3.0 release shipped contract artifact JSONs with
aztec_version: "dev"baked in which resulted in a failure in ci-compat-e2e as there we check the artifact version matches the expected tested version that is injected in via an env var.On npm.js we see "dev" in the artifact:
The issue seems to be caused by REF_NAME not being correctly populated when doing the release which then results in "dev" being stamped into the released artifacts instead of the real version.
The fix is to re-stamp the version into artifact when we are doing the release. It seems kinds 💩 tho