refactor(slasher): rename ATTESTED_DESCENDANT_OF_INVALID -> PROPOSED_DESCENDANT_OF_CHECKPOINT_WITH_INVALID_ATTESTATIONS#23468
Open
PhilWindle wants to merge 4 commits into
Conversation
…DESCENDANT_OF_INVALID Rename the slashing offence and its associated config knob, env var, helm value, and terraform variable to reflect that the slash now targets the proposer that publishes a descendant checkpoint to L1, not its attestors. Breaking for operators: SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY -> SLASH_PROPOSE_DESCENDANT_OF_INVALID_PENALTY (see v5.0.0 changelog).
…OINT_WITH_INVALID_ATTESTATIONS Rename the offence (and its config knob, env var, helm value, terraform variable, etc.) from the previous shorter PROPOSED_DESCENDANT_OF_INVALID form to spell out the exact condition: a descendant of a checkpoint that had invalid (or insufficient) attestations.
PhilWindle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes A-1073.
Rename the slashing offence (and its config knob, env var, helm value, terraform variable, deploy script, README, ops docs) so the name spells out the exact condition: a descendant of a checkpoint that had invalid (or insufficient) attestations. The behaviour change itself lives in A-1072 — this PR is rename-only.
OffenseType.ATTESTED_DESCENDANT_OF_INVALID→PROPOSED_DESCENDANT_OF_CHECKPOINT_WITH_INVALID_ATTESTATIONSslashAttestDescendantOfInvalidPenalty→slashProposeDescendantOfCheckpointWithInvalidAttestationsPenaltySLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY→SLASH_PROPOSE_DESCENDANT_OF_CHECKPOINT_WITH_INVALID_ATTESTATIONS_PENALTYTest plan
yarn build(yarn-project)yarn format,yarn lint slasher stdlib foundation aztec-nodeyarn workspace @aztec/slasher testyarn workspace @aztec/stdlib test src/slashingyarn workspace @aztec/stdlib test src/interfaces/aztec-node-admin.test.ts