feat: merge-train/spartan#23558
Merged
Merged
Conversation
Causes a warn when loaded in Codex
Tackles flake at [this run](http://ci.aztec-labs.com/f68773618307b3a1) by awaiting the close promise on the fork. ``` 22:00:44 ● NativeWorldState › Pending and Proven chain › does not fail when a delayed-close fork is destroyed by a reorg before its close fires 22:00:44 22:00:44 expect(received).toBe(expected) // Object.is equality 22:00:44 22:00:44 Expected: false 22:00:44 Received: true 22:00:44 22:00:44 964 | 22:00:44 965 | expect(warnSpy).not.toHaveBeenCalled(); 22:00:44 > 966 | expect((ws as any).instance.queues.has(forkId)).toBe(false); 22:00:44 | ^ 22:00:44 967 | }); 22:00:44 968 | }); 22:00:44 969 | 22:00:44 22:00:44 at Object.toBe (native/native_world_state.test.ts:966:55) ```
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
1 similar comment
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: frontmatter for update-doc-references (#23557)
test(ws): await close promise in native world state test (#23563)
END_COMMIT_OVERRIDE