test(ci): mark e2e_epochs/epochs_mbps_redistribution as flaky#24098
Merged
alexghr merged 1 commit intoJun 15, 2026
Conversation
The test asserts that all late txs land in the checkpoint's last block, but the proposer seals the last block as soon as one tx is available and snapshots the mempool, so late txs still propagating over gossip spill into the next checkpoint. This is a timing race in the sequencer, not a redistribution bug; a follow-up makes the last block collect txs until its build deadline. Until then, flag the test as a flake so it does not block the merge queue.
alexghr
approved these changes
Jun 15, 2026
PhilWindle
added a commit
that referenced
this pull request
Jun 15, 2026
The waitForBuildDeadlineOnFinalBlock flag enabled in this PR makes the test deterministic, so it no longer needs to be tolerated as a flake (added in #24098).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
src/e2e_epochs/epochs_mbps_redistribution.test.tsto.test_patterns.ymlas a flaky test so its failures alert owners rather than blocking the merge queue.Why
epochs_mbps_redistribution("redistributes checkpoint budget so late txs fit in the last block") dequeued #24053 from the merge queue by failing both its initial run and its retry. It is not a redistribution regression — it is a timing race in the sequencer:availableTxs >= 1(waitForMinTxs) and theniterateEligiblePendingTxsfreezes the tx set in a single mempool snapshot (p2p/src/client/p2p_client.ts).new Set(lateBlockNumbers).sizeis occasionally 2 instead of 1.The existing blanket entry
src/e2e_epochs/.*\.test\.tsonly tolerates this within thee2e-p2p-epoch-flakesgroup budget (flake_error_threshold: 5), which is why a hard failure still got through. This adds a dedicated, ungrouped entry so the specific test is always treated as a flake.Follow-up
This is the stop-gap. The real fix (separate PR) makes the final block of a checkpoint collect txs until its build deadline instead of sealing on the first available tx, which removes the race deterministically. Once that lands, this entry should be removed.