fix(kv-store): lazy-load skipped browser benchmark deps#24108
Merged
PhilWindle merged 1 commit intoJun 16, 2026
Conversation
mverzilli
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge-train/spartan-v5dequeue for train PR feat: merge-train/spartan-v5 #24053.merge-train/spartan-v5.27576008840ongh-readonly-queue/v5-next/pr-24053-fc2322d6..., failingci/x3-fullviayarn-project/kv-store/scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.ts.describe.skippath.VITE_BENCH=1for the IndexedDB, SQLite-OPFS, and encrypted SQLite-OPFS map benchmarks.Failed dashboard log: http://ci.aztec-labs.com/dbe70cb905f2df69
Verification
CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.tsfromyarn-project/kv-storepasses with the benchmark skipped.CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh src/bench/sqlite-opfs/map_bench.test.tspasses with the benchmark skipped.CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh src/bench/indexeddb/map_bench.test.tspasses with the benchmark skipped.yarn format kv-store --checkpasses.Notes: the requested root
./bootstrap.sh ciis not a valid bootstrap command in this checkout (Unknown command: ci). I also tried the apparent CI equivalent,./bootstrap.sh ci-full-no-test-cache; it did not complete in this container because the local CI engine/tooling failed before reaching these tests.Created by claudebox · group:
slackbot