refactor(pxe): restore satisfies-typed oracle registries#24132
Merged
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
mverzilli
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
satisfies Record<string, OracleRegistryEntry>form onORACLE_REGISTRYandTXE_ORACLE_REGISTRYfor explicitRecord<…>/ hand-maintained named-union annotations, widened the test resolver'sfixturesparameter toPartial<…>, and added an explicit return type ongetLastTxEffects.OracleRegistryEntry, which collapses the derived oracle interfaces (IMiscOracle/IUtilityExecutionOracle/IPrivateExecutionOracle) and the TXE roundtrip-test fixture types (OracleTestScenario<K>) down toany/string, silently dropping the per-oracle type checking that refactor(pxe)!: derive oracle interfaces from registry and introduce aztec_misc_ prefix #23840 and the oracle test framework were built to provide.satisfiesform, restoring the precise per-entry types.tsgodeclaration build,--noEmit, and lint all pass onpxeandtxe.