Skip to content

refactor(pxe): restore satisfies-typed oracle registries#24132

Merged
nchamo merged 1 commit into
merge-train/fairies-v5from
nchamo/oracle-clean-up
Jun 16, 2026
Merged

refactor(pxe): restore satisfies-typed oracle registries#24132
nchamo merged 1 commit into
merge-train/fairies-v5from
nchamo/oracle-clean-up

Conversation

@nchamo

@nchamo nchamo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • refactor(sequencer)!: always enforce timetable with concrete block duration #23821 (a sequencer-timetable refactor) incidentally rewrote the oracle registry typings: it swapped the satisfies Record<string, OracleRegistryEntry> form on ORACLE_REGISTRY and TXE_ORACLE_REGISTRY for explicit Record<…> / hand-maintained named-union annotations, widened the test resolver's fixtures parameter to Partial<…>, and added an explicit return type on getLastTxEffects.
  • Those annotations widen every registry entry to the generic OracleRegistryEntry, which collapses the derived oracle interfaces (IMiscOracle / IUtilityExecutionOracle / IPrivateExecutionOracle) and the TXE roundtrip-test fixture types (OracleTestScenario<K>) down to any / string, silently dropping the per-oracle type checking that refactor(pxe)!: derive oracle interfaces from registry and introduce aztec_misc_ prefix #23840 and the oracle test framework were built to provide.
  • This reverts those four type-level edits back to the satisfies form, restoring the precise per-entry types. tsgo declaration build, --noEmit, and lint all pass on pxe and txe.

@nchamo nchamo self-assigned this Jun 16, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/31253a5aad69bb0a�31253a5aad69bb0a8;;�): yarn-project/kv-store/scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.ts (1s) (code: 0)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/59d687d7f72f9096�59d687d7f72f90968;;�): yarn-project/kv-store/scripts/run_test.sh src/sqlite-opfs/internal/ordered-binary-browser.test.ts (1s) (code: 0)

@nchamo nchamo requested a review from mverzilli June 16, 2026 14:25
@nchamo nchamo merged commit ced146f into merge-train/fairies-v5 Jun 16, 2026
12 checks passed
@nchamo nchamo deleted the nchamo/oracle-clean-up branch June 16, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants