Skip to content

fix(bb-sol): run forge tests with pinned solc #24133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: merge-train/spartan-v5
Choose a base branch
from
Draft

fix(bb-sol): run forge tests with pinned solc #24133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions barretenberg/sol/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
source $(git rev-parse --show-toplevel)/ci3/source_bootstrap

export CRS_PATH="../cpp/srs_db"
export FOUNDRY_SOLC="${FOUNDRY_SOLC:-$(git rev-parse --show-toplevel)/l1-contracts/solc-0.8.30}"

export hash=$(cache_content_hash \
^barretenberg/sol/ \
Expand All @@ -19,7 +20,7 @@ function test_cmds {
}

function test_cmds_internal {
echo "cd barretenberg/sol && forge test --no-match-contract Base"
echo 'cd l1-contracts && ./bootstrap.sh download_solc && cd ../barretenberg/sol && FOUNDRY_SOLC=../../l1-contracts/solc-0.8.30 forge test --offline --no-match-contract Base'
}

function build_sol {
Expand All @@ -34,7 +35,7 @@ function build_sol {
git submodule update --init --recursive ./lib

forge fmt || true
denoise "forge build"
denoise "forge build --offline"

cache_upload $artifact out
fi
Expand Down Expand Up @@ -77,7 +78,7 @@ function bench {
# Run forge test with gas report using JSON flag
echo "Running gas report for verifier contracts..."
# Do not include foundry std err messages in the output
FORGE_GAS_REPORT=true forge test --no-match-contract Base --mt "(testValidProof|test_ValidProof)" --json 2>&1 | grep -v "non-empty stderr" > gas_report.json
FORGE_GAS_REPORT=true forge test --offline --no-match-contract Base --mt "(testValidProof|test_ValidProof)" --json 2>&1 | grep -v "non-empty stderr" > gas_report.json

# Check if we got any output
if [ ! -s gas_report.json ]; then
Expand Down
Loading