fix(e2e): make attested invalid proposal slot selection robust#24338
Closed
AztecBot wants to merge 1 commit into
Closed
fix(e2e): make attested invalid proposal slot selection robust#24338AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Contributor
|
Closing in favor of #24339, which keeps the existing epoch-boundary selection logic and only increases the attempt window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the merge-queue failure that dequeued aztec-packages#24331. The failed merge-group run was not a merge conflict;
x5-fullfailed inyarn-project/end-to-end/src/e2e_slashing/attested_invalid_proposal.test.tsbecauseadvanceToEpochBeforePipelinedTargetSlotonly accepted the second slot of the next epoch. In the failing run, the bad proposer was repeatedly assigned to the first slot instead.This changes the helper to scan all slots in the next epoch, choose the first slot assigned to the target proposer, and warp to the pipelined build slot (
targetSlot - PROPOSER_PIPELINING_SLOT_OFFSET) before waiting for the bad proposal.Verification
./bootstrap.sh cifrom repo root: fails immediately because this branch has no rootcicommand (Unknown command: ci).yarn-project/bootstrap.sh format --check end-to-end: pass.yarn-project/bootstrap.sh compile: pass.yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_slashing/attested_invalid_proposal.test.ts "slashes a lazy attester for an invalid checkpoint and clears it on delayed equivocation", but local execution is blocked by missing generated protocol/L1 artifacts (protocol_contract_data.js,@aztec/l1-artifacts, Noir contract JSON). The dependency-aware root build needed to produce them is blocked in this container by Noir'sjust@1.42.4install failing to reach crates.io through the proxy.Created by claudebox · group:
slackbot