Skip to content

test(sequencer-client): fix checkpoint proposal job timetable setup#24346

Merged
spalladino merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-checkpoint-job-ci
Jun 27, 2026
Merged

test(sequencer-client): fix checkpoint proposal job timetable setup#24346
spalladino merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-checkpoint-job-ci

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

  • Ensure fresh jobs created in the single-block checkpoint proposal tests use the same one-block timetable as the describe setup.
  • Make the pipelined parent helper explicitly use that one-block timetable and start at the pipelined build-frame opening.

Investigation

PR #24331 was dequeued after the merge-queue run for synthetic commit 08e8db39e998b8a5ad95b09039de2befd48e144f failed ci/x3-full. The failed test log for yarn-project/scripts/run_test.sh sequencer-client/src/sequencer/checkpoint_proposal_job.test.ts showed TypeError: Cannot read properties of undefined (reading 'getStats') at block.getStats() in checkpoint_proposal_job.ts.

The test helpers seeded a single mock block, but some freshly-created pipelined jobs kept the default multi-block timetable instead of the single-block timetable. With no-op waits in the test subclass, the job attempted a second block build, exhausted MockCheckpointBuilder, and returned an undefined block.

Verification

  • MAKEFILE_TARGET=yarn-project yarn-project/scripts/run_test.sh sequencer-client/src/sequencer/checkpoint_proposal_job.test.ts (46 passed)
  • ./bootstrap.sh ci exits immediately with Unknown command: ci on this branch; the root bootstrap defines ci-fast/ci-full, not plain ci.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 27, 2026
@spalladino spalladino marked this pull request as ready for review June 27, 2026 02:05
@spalladino spalladino enabled auto-merge (squash) June 27, 2026 02:06
@spalladino spalladino merged commit 61a53ba into merge-train/spartan-v5 Jun 27, 2026
43 of 47 checks passed
@spalladino spalladino deleted the cb/fix-spartan-v5-checkpoint-job-ci branch June 27, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants