Skip to content

fix: repair fairies v5 benchmark CI failures#24347

Draft
AztecBot wants to merge 2 commits into
merge-train/fairies-v5from
cb/fix-fairies-v5-dequeue
Draft

fix: repair fairies v5 benchmark CI failures#24347
AztecBot wants to merge 2 commits into
merge-train/fairies-v5from
cb/fix-fairies-v5-dequeue

Conversation

@AztecBot

@AztecBot AztecBot commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Refs aztec-packages#24223.

The latest merge-queue dequeue for aztec-packages#24223 was from CI3 run 28272090637, job 83771340260, not a merge conflict. The train PR is mergeable/clean; the dequeue came from CI failures in benchmark/test execution.

Failures found in the CI dashboard logs:

  • client_flows/amm: expected 14 private execution steps, got 17 for ecdsar1 + sponsored_fpc AMM add-liquidity.
  • client_flows/transfers: expected 11/13 private execution steps, got 13/14 for private_fpc transfers.
  • bench_build_block: repeated sender tagging failures at index 21 with UNFINALIZED_TAGGING_INDEXES_WINDOW_LEN = 20.

This PR:

  • Updates the benchmark app-call accounting for private FPC fee-note reception.
  • Updates the AMM benchmark expected app-call count for offchain note reception of the two token transfers.
  • Ties the unfinalized tagging window to MAX_PRIVATE_LOGS_PER_TX so benchmark blocks can keep several same-secret txs pending.
  • Updates the recipient-sync batching test to expect RPC-cap chunking now that the window is larger than the node tag-request limit when combined across multiple secrets.

Verification

  • git diff --check
  • .claude/tests/agents_symlink_test
  • CI3 run 28274656756 passed on current head a842b16424a0ead826c998b1c52b933eac44cbb7.
  • ./bootstrap.sh ci was attempted as requested, but this checkout's root bootstrap does not define a bare ci command (Unknown command: ci). It also cannot connect to Docker for local Redis in this container.
  • Focused local Jest for sync_tagged_private_logs.test.ts was attempted, but Yarn is not installed/generated in this workspace (Couldn't find the node_modules state file).

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 27, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/974ad17597d0a74a�974ad17597d0a74a8;;�): yarn-project/kv-store/scripts/run_test.sh src/bench/sqlite-opfs-encrypted/map_bench.test.ts (2s) (code: 0)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/ca52c19ccb4c15e8�ca52c19ccb4c15e88;;�): yarn-project/kv-store/scripts/run_test.sh src/sqlite-opfs/internal/ordered-binary-browser.test.ts (2s) (code: 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant