feat(keys)!: add derivation for message-signing and fallback keys#24348
Draft
nchamo wants to merge 3 commits into
Draft
feat(keys)!: add derivation for message-signing and fallback keys#24348nchamo wants to merge 3 commits into
nchamo wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we are doing this
#23510 added the message-signing (
mspk) and fallback (fbpk) keys to the protocolPublicKeys, but baked them into the address commitment as fixed default values with no derivation path. This gives both keys real per-account derivations.The message-signing key is the prerequisite for interactive handshakes: a recipient's consent signature is verified against
mspk.Our fix
deriveKeysderivesmssk/fbskand populates themspk/fbpkhashes from them, instead of the shared default constants.Because the
mspk/fbpkhashes feedPublicKeys::hash(), every account address derived from a secret changes — hence the breaking flag. Standard and protocol contracts derive fromPublicKeys::default()(unchanged), so their addresses are unaffected.