Skip to content

fix: improve valkeys password handling#24459

Merged
alexghr merged 1 commit into
merge-train/spartanfrom
stack/fix-improve-valkeys-password-handling-a-1359
Jul 3, 2026
Merged

fix: improve valkeys password handling#24459
alexghr merged 1 commit into
merge-train/spartanfrom
stack/fix-improve-valkeys-password-handling-a-1359

Conversation

@alexghr

@alexghr alexghr commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fix A-1359

@alexghr
alexghr force-pushed the stack/fix-improve-valkeys-password-handling-a-1359 branch from 47abab6 to 4ddfd74 Compare July 2, 2026 14:38
@AztecBot

AztecBot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/dc4d53ad61270eb3�dc4d53ad61270eb38;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_mbps.pipeline.parallel.test.ts "pipelining builds blocks using slot plus 1 proposer and proves them" (283s) (code: 0) group:e2e-p2p-epoch-flakes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, should probably be passwordString

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that this needs to be any?

@alexghr
alexghr enabled auto-merge (squash) July 3, 2026 07:57
@alexghr
alexghr merged commit ebe8b1a into merge-train/spartan Jul 3, 2026
24 checks passed
@alexghr
alexghr deleted the stack/fix-improve-valkeys-password-handling-a-1359 branch July 3, 2026 07:58
AztecBot pushed a commit that referenced this pull request Jul 3, 2026
@AztecBot

AztecBot commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

✅ Successfully backported to backport-to-v5-next-staging #24497.

alexghr added a commit that referenced this pull request Jul 3, 2026
AztecBot pushed a commit that referenced this pull request Jul 3, 2026
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request Jul 7, 2026
BEGIN_COMMIT_OVERRIDE
fix: improve valkeys password handling (AztecProtocol#24459)
chore: pin pako (AztecProtocol#24501)
feat: allow separate valkeys passwords. (AztecProtocol#24460)
chore: loosen alert routing rules (AztecProtocol#24499)
chore: default metrics-deploy Slack alert mention to ClaudeBox (AztecProtocol#24484)
feat: speed up valkeys generation (AztecProtocol#24467)
fix(release-image): stamp stdlib/package.json with release version
(AztecProtocol#24410)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants