fix(ci): avoid redundant heavy queue benches#24468
Closed
AztecBot wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: AztecProtocol/aztec-packages#24454
Summary
BENCH_UPLOAD=0to every non-primarymulti_job_runshardci-fullandci-full-no-test-cacheskip the post-testbenchwhenBENCH_UPLOAD=0BENCH_UPLOAD=1Investigation
The dequeued merge-group run did not fail from a merge conflict. PR #24454 is mergeable and its head CI passed. The failed merge-group run had tests complete successfully on the failing full shards, then both
ci/x7-fullandci/x9-fullenteredbench allbefore being marked failed. The later merge-group run similarly had all observed full shards pass tests, with a remaining shard still spending time inbench all.This change keeps one benchmark artifact producer and removes the redundant post-test benchmark sweeps from the other heavy queue shards.
Testing
bash -n ci.sh && bash -n bootstrap.sh && git diff --checkBENCH_UPLOAD=0gate check:bench_if_enabledskips, while the default path callsbench./bootstrap.sh ci, but this ref does not define acitarget and exits withUnknown command: cishellcheck ci.sh bootstrap.shunavailable:shellcheckis not installed in this containerCreated by claudebox · group:
slackbot