fix(txe): align aztec_avm_returndataSize registry type with Noir u32#24480
Merged
nventuro merged 1 commit intoJul 2, 2026
Merged
Conversation
The registry declared FIELD for aztec_avm_returndataSize while the Noir oracle returns u32. Change the entry to U32 and the handler signature to return a number, matching every other AVM size/gas field. The wire format is unchanged (both serialize to a single field element), so only the TXE oracle interface hash is updated, with no version bump. Also replace stale docstring references to the removed #[auto_serialization_test] macro with #[generate_oracle_tests].
nventuro
enabled auto-merge (squash)
July 2, 2026 20:43
nchamo
approved these changes
Jul 2, 2026
nchamo
left a comment
Contributor
There was a problem hiding this comment.
Nice catch on the outdated docs. Thanks!
This was referenced Jul 2, 2026
vezenovm
pushed a commit
that referenced
this pull request
Jul 2, 2026
…4482) ## Problem CI on `merge-train/fairies-v5` is red at the `yarn-project` build step ([ci.aztec-labs.com/1783026321562696](http://ci.aztec-labs.com/1783026321562696)). The `compile_all` → `yarn tsgo -b --emitDeclarationOnly` typecheck fails with: ``` wallet-sdk/src/base-wallet/base_wallet.ts(375,36): error TS2339: Property 'address' does not exist on type 'ContractInstancePreimage'. wallet-sdk/src/base-wallet/base_wallet.ts(377,113): error TS2339: Property 'address' does not exist on type 'ContractInstancePreimage'. ``` These two were the complete set of errors reported by the (non-fail-fast) tsgo pass. ## Root cause This is a train-integration break, not a defect in the commit the CI run is attributed to (#24480, which only touched a TXE registry type). On the `v5-next` base, `ContractInstancePreimage` was refactored to no longer store a derived `address` field (address is now computed from the preimage; the with-address variant is the separate `ContractInstancePreimageWithAddress`). The fairies train's rewrite of `BaseWallet.registerContract` still read `instance.address`, which no longer exists on that type. ## Fix `PXE.registerContract(instance)` already returns the derived `AztecAddress` (it computes `computeContractAddressFromInstance(instance)` internally). Capture and use that returned address for the account-mismatch assertion instead of the removed `instance.address` field. This is semantically identical — the returned value is exactly the address the field used to hold — and touches only the two failing references. ## Verification The workspace this fix was prepared in is a bare checkout with no build/test cache available (no redis/docker) and insufficient free disk for a from-scratch `bb` + `noir` + TS build, so a full local `./bootstrap.sh ci-fast` could not be run to completion. The change is verified by inspection against the type definitions and the `PXE.registerContract` return contract; CI on this PR will exercise the real build. --- *Created by [claudebox](https://claudebox.work/v2/sessions/8542372f24dbb848) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was set to Field but was u32. I also adjusted some slightly outdated comments.