refactor(aztec-nr): keep handshake secrets internal to TagSecretSource#24508
Merged
Conversation
nchamo
added
ci-draft
nchamo
marked this pull request as ready for review
July 3, 2026 16:43
vezenovm
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TagSecretSource::obtain_secretsreturnedAppSiloedHandshakeSecretsfor every source kind. That was wrong: the pair only makes sense for handshake-backed sources, and the unconstrained kind had to fakesender_only: 0. It appears this leaked in automatically during a Claude conflict resolution.resolve_tag_secretreturns theFieldthe tag derives from, andconstrain_tag_secretanchors the sequence and emits the sequence nullifier itself.AppSiloedHandshakeSecretsstays where it is honest: the registry wire type, the constrained-delivery helpers, and the source's internal payload.