Skip to content

perf(e2e): batch same-sender setup txs into single txs #24584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spalladino wants to merge 1 commit into from
Closed

perf(e2e): batch same-sender setup txs into single txs #24584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions yarn-project/end-to-end/src/single-node/fees/fees_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { AztecAddress } from '@aztec/aztec.js/addresses';
import { BatchCall } from '@aztec/aztec.js/contracts';
import { Fr } from '@aztec/aztec.js/fields';
import { createLogger } from '@aztec/aztec.js/log';
import type { AztecNode } from '@aztec/aztec.js/node';
Expand Down Expand Up @@ -401,16 +402,24 @@ export class FeesTest extends SingleNodeTestContext {
public async applyFundAliceWithBananas() {
this.logger.info('Applying fund Alice with bananas setup');

// The private and public mints touch disjoint balances, so they are sent concurrently to share a
// slot instead of paying one slot each.
await Promise.all([
this.mintPrivateBananas(this.ALICE_INITIAL_BANANAS, this.aliceAddress),
testSpan('tx:mint', () =>
this.bananaCoin.methods.mint_to_public(this.aliceAddress, this.ALICE_INITIAL_BANANAS).send({
from: this.aliceAddress,
}),
),
]);
// Both mints are alice sends on BananaCoin touching disjoint balances, so they ride a single
// BatchCall tx (one proof, one slot) rather than two concurrent txs. The PXE serializes proving,
// so two concurrent sends would still be proven back-to-back and land in consecutive slots.
const { result: privateBalanceBefore } = await this.bananaCoin.methods
.balance_of_private(this.aliceAddress)
.simulate({ from: this.aliceAddress });

await testSpan('tx:mint', () =>
new BatchCall(this.wallet, [
this.bananaCoin.methods.mint_to_private(this.aliceAddress, this.ALICE_INITIAL_BANANAS),
this.bananaCoin.methods.mint_to_public(this.aliceAddress, this.ALICE_INITIAL_BANANAS),
]).send({ from: this.aliceAddress }),
);

const { result: privateBalanceAfter } = await this.bananaCoin.methods
.balance_of_private(this.aliceAddress)
.simulate({ from: this.aliceAddress });
expect(privateBalanceAfter).toEqual(privateBalanceBefore + this.ALICE_INITIAL_BANANAS);
}

public async applyFundAliceWithPrivateBananas() {
Expand Down
Loading