feat: weblock controlled opfs pool - #24740
Merged
Merged
Conversation
Thunkar
approved these changes
Jul 16, 2026
Thunkar
left a comment
Thunkar
left a comment
Collaborator
There was a problem hiding this comment.
Lovely, and the error is much more descriptive!
Base automatically changed from
gj/sqlite_corruption_escape
to
merge-train/fairies-v5
July 16, 2026 08:10
mverzilli
added a commit
that referenced
this pull request
Jul 17, 2026
This is a defensive measure in case more than one SQLite page file is found pointing to the same logical name, which could cause undefined behavior. This could happen with old, pre-weblock controlled versions of wallet/pxe (see #24740), so it's unlikely to be found in the wild, but it gives us graceful coverage if that happens. We detect if a pool contains two valid .opaque files mapped to the same logical SQLite path, then: 1. Acquire the pool Web Lock. 2. Copy the entire pool byte-for-byte into: .aztec-sqlite-quarantine/<timestamp-random>/ 3. Verify the copied directory and file contents. 4. Write a quarantine.json describing the duplicate mappings. 5. Delete the original active pool. 6. Open a new, empty database under the original pool name. 7. Emit a warning log containing the quarantine location. The caller receives a successfully opened but empty store, so wallet/PXE state would need to be recreated or resynchronized. The quarantined bytes remain available for forensic or manual recovery, although there is currently no public API or UI for that. If copying or verification fails, opening fails and the original pool is not intentionally removed. If the pool merely comes from an old version but has no duplicate logical mappings, nothing special happens, it opens normally. --------- Co-authored-by: Gregorio Juliana <gregojquiros@gmail.com>
This was referenced Jul 17, 2026
PhilWindle
added
port-to-next
PhilWindle
pushed a commit
that referenced
this pull request
Jul 21, 2026
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents multi-tab concurrency issues in SQLite store creation by guarding it with weblocks.
Closes F-829