Skip to content

fix(bb): avoid debug abort in acir components missing witness test #24782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AztecBot wants to merge 1 commit into from
Closed

fix(bb): avoid debug abort in acir components missing witness test #24782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions barretenberg/cpp/src/barretenberg/acir_components_check/components_check.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,16 @@ std::vector<acir_components_check::Error> run_components_check(const Acir::Circu
return checker.check();
}

std::vector<acir_components_check::Error> run_components_check_with_builder_circuit(
const Acir::Circuit& acir_circuit, const Acir::Circuit& builder_circuit)
{
auto constraints = circuit_serde_to_acir_format(builder_circuit, IsMegaBuilder<AcirComponentsCheckBuilder>);
AcirProgram program{ .constraints = constraints, .witness = {} };
auto builder = create_circuit<AcirComponentsCheckBuilder>(program);
acir_components_check::ComponentsChecker checker(acir_circuit, builder);
return checker.check();
}

void expect_no_component_errors(const std::vector<acir_components_check::Error>& errors)
{
if (errors.empty()) {
Expand Down Expand Up @@ -544,7 +554,18 @@ TEST_F(AcirComponentsCheckTest, DetectsSplitComponents)

TEST_F(AcirComponentsCheckTest, DetectsUnconstrainedWitnesses)
{
Acir::Circuit circuit = make_circuit({
Acir::Circuit acir_circuit = make_circuit({
Acir::Opcode{ .value = Acir::Opcode::AssertZero{
.value = Acir::Expression{
.linear_combinations =
{
{ bb::fr::one().to_buffer(), make_witness(8) },
{ bb::fr(-1).to_buffer(), make_witness(1000) },
},
.q_c = bb::fr::zero().to_buffer(),
} } },
});
Acir::Circuit builder_circuit = make_circuit({
Acir::Opcode{ .value = Acir::Opcode::AssertZero{
.value = Acir::Expression{
.linear_combinations =
Expand All @@ -556,14 +577,10 @@ TEST_F(AcirComponentsCheckTest, DetectsUnconstrainedWitnesses)
} } },
});

auto constraints = circuit_serde_to_acir_format(circuit, IsMegaBuilder<AcirComponentsCheckBuilder>);
AcirProgram program{ .constraints = constraints, .witness = {} };
auto builder = create_circuit<AcirComponentsCheckBuilder>(program);
// Corrupt the circuit
builder.real_variable_index.resize(9);

acir_components_check::ComponentsChecker checker(circuit, builder);
auto errors = checker.check();
// Model an ACIR-vs-circuit mismatch without corrupting the builder's internal witness map.
// Truncating real_variable_index violates the builder invariant and aborts in debug STL checks
// before ComponentsChecker can report the intended UNCONSTRAINED error.
auto errors = run_components_check_with_builder_circuit(acir_circuit, builder_circuit);
expect_single_error_type(errors, acir_components_check::Error::Type::UNCONSTRAINED);
}

Expand Down
Loading