Skip to content

fix(ci3): make redis_setexz a no-op instead of crashing bootstrap_ec2 when redis is unavailable #24823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

fix(ci3): make redis_setexz a no-op instead of crashing bootstrap_ec2 when redis is unavailable #24823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ci3/source_redis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,16 @@ function redis_cli {
}

function redis_setexz {
gzip | redis_cli -x SETEX $1 $2 &>/dev/null
# When redis is unavailable, redis_cli is a no-op that never reads its stdin, so a
# bare `gzip | redis_cli` leaves gzip writing into an already-closed pipe. gzip dies
# with "gzip: stdout: Broken pipe" and, under `set -euo pipefail`, that aborts the
# whole run at the first log write (e.g. the nightly debug build, which has no redis
# on the GitHub-hosted runner). Drain stdin instead so the producer completes cleanly.
if [ "${CI_REDIS_AVAILABLE:-0}" -eq 1 ]; then
gzip | redis_cli -x SETEX $1 $2 &>/dev/null
else
cat >/dev/null
fi
}

function redis_getz {
Expand Down
Loading