Skip to content

Commit 20e5827

Browse files
critesjoshclaude
andcommitted
fix: handle logging edge cases from review feedback
- Catch sendLoggingMessage rejections to prevent unhandled promise rejections when the client disconnects during sync - Only pass logger arg to cloneRepo when defined, preserving the two-argument call contract for callers without logging Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b340300 commit 20e5827

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
203203
level: level as "info" | "debug" | "warning" | "error",
204204
logger: "aztec-sync",
205205
data: message,
206-
});
206+
}).catch(() => {});
207207
};
208208
const result = await syncRepos({
209209
version: args?.version as string | undefined,

src/tools/sync.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export async function syncRepos(options: {
5555
syncIndex++;
5656
log?.(`Syncing ${syncIndex}/${reposToSync.length}: ${config.name}`, "info");
5757
try {
58-
const status = await cloneRepo(config, force, log);
58+
const status = log ? await cloneRepo(config, force, log) : await cloneRepo(config, force);
5959
results.push({ name: config.name, status: statusTransform ? statusTransform(status) : status });
6060
} catch (error) {
6161
log?.(`${config.name}: Failed: ${error instanceof Error ? error.message : String(error)}`, "error");

0 commit comments

Comments
 (0)