girdershi pt.3

Author: cakeGit

src/main/java/com/kipti/bnb/content/girder_strut/GirderStrutModelBuilder.java

@@ -12,6 +12,7 @@
 import net.neoforged.neoforge.client.model.BakedModelWrapper;
 import net.neoforged.neoforge.client.model.data.ModelData;
 import net.neoforged.neoforge.client.model.data.ModelProperty;
+import net.neoforged.neoforge.common.util.TriState;
 import org.jetbrains.annotations.NotNull;
 
 import java.util.ArrayList;
@@ -57,6 +58,21 @@ public List<BakedQuad> getQuads(BlockState state, Direction side, RandomSource r
         return base;
     }
 
+    @Override
+    public TriState useAmbientOcclusion(BlockState state, ModelData data, RenderType renderType) {
+        return TriState.FALSE;
+    }
+
+    @Override
+    public boolean useAmbientOcclusion() {
+        return false;
+    }
+
+    @Override
+    public boolean usesBlockLight() {
+        return false;
+    }
+
     static final class GirderStrutModelData {
         private final List<GirderConnection> connections;
 
@@ -91,7 +107,7 @@ static GirderStrutModelData collect(BlockAndTintGetter level, BlockPos pos, Bloc
                     continue;
                 }
                 Vec3 halfVector = span.scale(0.5);
-                double renderLength = halfVector.length();
+                double renderLength = halfVector.length() + 0.5f;
                 if (renderLength <= 1.0e-4) {
                     continue;
                 }

src/main/java/com/kipti/bnb/content/girder_strut/GirderStrutModelManipulator.java

@@ -55,7 +55,7 @@ static List<BakedQuad> bakeConnection(GirderStrutModelBuilder.GirderConnection c
         poseStack.translate(connection.start().x, connection.start().y, connection.start().z);
         poseStack.mulPose(new Quaternionf().rotationY(yRot));
         poseStack.mulPose(new Quaternionf().rotationX(-xRot));
-        poseStack.translate(-0.5f, -0.5f, 0.0f);
+        poseStack.translate(-0.5f, -0.5f, -0.5f);
 
 
         PoseStack.Pose last = poseStack.last();
@@ -244,9 +244,16 @@ MeshQuad clipZ(float maxZ) {
                 return this;
             }
             if (maxZ <= minZ + EPSILON) {
-                return null;
+                float translation = maxZ - maxOriginalZ;
+                Vertex[] shifted = new Vertex[vertices.length];
+                for (int i = 0; i < vertices.length; i++) {
+                    Vertex vertex = vertices[i];
+                    Vector3f pos = new Vector3f(vertex.position()).add(0f, 0f, translation);
+                    shifted[i] = new Vertex(pos, new Vector3f(vertex.normal()), vertex.u(), vertex.v(), vertex.color(), vertex.light());
+                }
+                // Move the fully sliced quad back to the cut plane so the end face is preserved.
+                return new MeshQuad(shifted, sprite, nominalFace, tintIndex, shade);
             }
-
             List<Vertex> clipped = new ArrayList<>();
 
             for (int i = 0; i < vertices.length; i++) {

src/main/resources/assets/bits_n_bobs/models/block/girder_strut/normal_girder_strut_attachment.json

@@ -6,73 +6,5 @@
     "particle": "create:block/industrial_iron_block"
   },
   "elements": [
-    {
-      "from": [
-        0,
-        0,
-        0
-      ],
-      "to": [
-        16,
-        5,
-        16
-      ],
-      "faces": {
-        "north": {
-          "uv": [
-            0,
-            0,
-            16,
-            5
-          ],
-          "texture": "#0"
-        },
-        "east": {
-          "uv": [
-            0,
-            0,
-            16,
-            5
-          ],
-          "texture": "#0"
-        },
-        "south": {
-          "uv": [
-            0,
-            0,
-            16,
-            5
-          ],
-          "texture": "#0"
-        },
-        "west": {
-          "uv": [
-            0,
-            0,
-            16,
-            5
-          ],
-          "texture": "#0"
-        },
-        "up": {
-          "uv": [
-            16,
-            16,
-            0,
-            0
-          ],
-          "texture": "#0"
-        },
-        "down": {
-          "uv": [
-            16,
-            0,
-            0,
-            16
-          ],
-          "texture": "#0"
-        }
-      }
-    }
   ]
 }