Skip to content

Commit dfa62da

Browse files
Refine markdown instructions
1 parent 2588725 commit dfa62da

4 files changed

Lines changed: 15 additions & 5 deletions

File tree

.github/agents/apim-sample-creator.agent.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
---
22
name: APIM Sample Creator
3+
.
34
description: "Use when adding or scaffolding an APIM sample, designing its notebook versus sample-local helper boundary, creating from samples/_TEMPLATE, or updating README, website, slide deck, and compatibility listings."
45
tools: [read, search, edit, todo]
56
argument-hint: "Describe the sample to add, including its sample name, display name, supported infrastructures, scenario, and any APIs or policies."
@@ -58,7 +59,7 @@ You are the specialist for adding new samples to the APIM Samples repository.
5859
5. Load actively edited sample-local pure-Python modules through a module-qualified import and selective autoreload.
5960
6. Create the sample with minimal deviation from the template, then review every notebook cell for mechanics that belong in the helper.
6061
7. Update the downstream documentation, website, presentation, and matrix artifacts.
61-
8. Run focused lint/tests followed by the combined repository checks. Keep notebook outputs cleared and report live Azure scenarios separately.
62+
8. Run markdownlint on all changed Markdown files and require zero violations. Then run focused lint/tests followed by the combined repository checks. Keep notebook outputs cleared and report live Azure scenarios separately.
6263
9. Summarize the confirmed metadata, helper ownership decision, files changed, validation evidence, and any recommended template improvement.
6364

6465
## Output Format

.github/agents/apim-sample-publisher.agent.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,16 @@ Treat search visibility as a publication criterion, not as optional polish. Revi
7373
./tests/python/check_python.sh
7474
```
7575

76-
10. Export the self-contained presentation and treat warnings about missing images as failures to investigate:
76+
10. Run markdownlint on all changed Markdown files and require zero violations. Fix violations instead of disabling rules unless a narrowly scoped suppression is necessary and documented.
77+
11. Export the self-contained presentation and treat warnings about missing images as failures to investigate:
7778

7879
```bash
7980
uv run python setup/export_presentation.py
8081
```
8182

82-
11. Run the SEO pass when public website content changed. Parse the inline JSON-LD block and `docs/sitemap.xml`, then verify that structured-data entries and visible cards stay synchronized.
83-
12. Preview the staged website when website or deck content changed. Use `uv run python setup/serve_website.py` and review both the landing page and `/slide-deck.html`. Check desktop and narrow layouts when visual changes are material.
84-
13. Inspect the final diff after validation. Do not include generated artifacts such as `build/`, `_site/`, coverage files, or lint reports unless the repository intentionally tracks them.
83+
12. Run the SEO pass when public website content changed. Parse the inline JSON-LD block and `docs/sitemap.xml`, then verify that structured-data entries and visible cards stay synchronized.
84+
13. Preview the staged website when website or deck content changed. Use `uv run python setup/serve_website.py` and review both the landing page and `/slide-deck.html`. Check desktop and narrow layouts when visual changes are material.
85+
14. Inspect the final diff after validation. Do not include generated artifacts such as `build/`, `_site/`, coverage files, or lint reports unless the repository intentionally tracks them.
8586

8687
When live Azure validation is relevant but not requested or not available, report the exact notebook scenario and supported infrastructure combinations that remain to be exercised. Do not substitute unit tests for live scenario evidence.
8788

.github/copilot-instructions.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ Check `docs/README.md` for local preview instructions and styling notes. The pag
502502

503503
## Required before each commit
504504
- Ensure all code is well-documented and follows the guidelines in this file.
505+
- Ensure markdownlint passes with zero violations for all new or modified Markdown files.
505506
- Ensure that Jupyter notebooks do not contain any cell output.
506507
- Ensure that Jupyter notebooks have `index` assigned to `1` in the first cell.
507508
- If the change touches the infrastructure list, sample list, quick-start steps, or architecture SVGs, ensure `docs/index.html` (and the asset copy step in `.github/workflows/github-pages.yml` where relevant) has been updated to match.

.github/markdown.instructions.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ This document provides standards for Markdown files in the APIM Samples reposito
88

99
## Critical Rules
1010

11+
### Markdownlint Must Pass
12+
13+
- Every new or modified Markdown file must pass markdownlint with zero violations before the work is considered complete.
14+
- Run markdownlint against all changed `.md` files using the available CLI or VS Code diagnostics.
15+
- Fix violations instead of disabling rules. Add a narrowly scoped suppression only when the Markdown intentionally cannot comply, and explain why next to the suppression.
16+
1117
### 🚨 No Emoji Variation Selectors in Markdown Links
1218

1319
**This is the most important rule.** Emoji variation selectors cause rendering and Markdown anchor link failures.
@@ -223,6 +229,7 @@ Structured guides for domain-specific tasks (Bicep, Python policies, sample crea
223229

224230
| Issue | Cause | Fix |
225231
| --- | --- | --- |
232+
| Markdownlint failure | Markdown does not meet the configured lint rules | Fix every reported violation and rerun markdownlint |
226233
| Anchor links break | Emoji in heading + encoded in link | Remove emoji from link reference: `[text](#heading-only)` |
227234
| Tables misaligned | Inconsistent column widths | Pad cells with spaces to align `\|` delimiters |
228235
| File links broken | Wrong path or encoded characters | Use relative paths, encode spaces: `My%20File.md` |

0 commit comments

Comments
 (0)