Merge pull request #64 from peterdrier/msalv3

Comments to help users new to the Authorization space.

Author: jennyf19

active-directory-b2c-wpf/App.xaml.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using System;
 using System.IO;
 using System.Text;
 using System.Windows;
@@ -13,16 +14,45 @@ namespace active_directory_b2c_wpf
     /// </summary>
     public partial class App : Application
     {
-        private static readonly string Tenant = "fabrikamb2c.onmicrosoft.com";
-        private static readonly string AzureAdB2CHostname = "fabrikamb2c.b2clogin.com";
+        /// <summary>
+        /// B2C tenant name
+        /// </summary>
+        private static readonly string TenantName = "fabrikamb2c";
+        private static readonly string Tenant = $"{TenantName}.onmicrosoft.com";
+        private static readonly string AzureAdB2CHostname = $"{TenantName}.b2clogin.com";
+
+        /// <summary>
+        /// ClientId for the application which initiates the login functionality (this app)  
+        /// </summary>
         private static readonly string ClientId = "841e1190-d73a-450c-9d68-f5cf16b78e81";
+
+        /// <summary>
+        /// Should be one of the choices on the Azure AD B2c / [This App] / Authentication blade
+        /// </summary>
         private static readonly string RedirectUri = "https://fabrikamb2c.b2clogin.com/oauth2/nativeclient";
+
+        /// <summary>
+        /// From Azure AD B2C / UserFlows blade
+        /// </summary>
         public static string PolicySignUpSignIn = "b2c_1_susi";
         public static string PolicyEditProfile = "b2c_1_edit_profile";
         public static string PolicyResetPassword = "b2c_1_reset";
 
+        /// <summary>
+        /// Note: AcquireTokenInteractive will fail to get the AccessToken if "Admin Consent" has not been granted to this scope.  To achieve this:
+        /// 
+        /// 1st: Azure AD B2C / App registrations / [API App] / Expose an API / Add a scope
+        /// 2nd: Azure AD B2C / App registrations / [This App] / API Permissions / Add a permission / My APIs / [API App] / Select & Add Permissions
+        /// 3rd: Azure AD B2C / App registrations / [This App] / API Permissions / ... (next to add a permission) / Grant Admin Consent for [tenant]
+        /// </summary>
         public static string[] ApiScopes = { "https://fabrikamb2c.onmicrosoft.com/helloapi/demo.read" };
+
+        /// <summary>
+        /// URL for API which will receive the bearer token corresponding to this authentication
+        /// </summary>
         public static string ApiEndpoint = "https://fabrikamb2chello.azurewebsites.net/hello";
+
+        // Shouldn't need to change these:
         private static string AuthorityBase = $"https://{AzureAdB2CHostname}/tfp/{Tenant}/";
         public static string AuthoritySignUpSignIn = $"{AuthorityBase}{PolicySignUpSignIn}";
         public static string AuthorityEditProfile = $"{AuthorityBase}{PolicyEditProfile}";
@@ -35,18 +65,16 @@ static App()
             PublicClientApp = PublicClientApplicationBuilder.Create(ClientId)
                 .WithB2CAuthority(AuthoritySignUpSignIn)
                 .WithRedirectUri(RedirectUri)
-                .WithLogging(Log, LogLevel.Info, false) // don't log PII details on a regular basis
+                .WithLogging(Log, LogLevel.Info, false) // don't log P(ersonally) I(dentifiable) I(nformation) details on a regular basis
                 .Build();
 
             TokenCacheHelper.Bind(PublicClientApp.UserTokenCache);
         }
+
         private static void Log(LogLevel level, string message, bool containsPii)
         {
-            string logs = ($"{level} {message}");
-            StringBuilder sb = new StringBuilder();
-            sb.Append(logs);
-            File.AppendAllText(System.Reflection.Assembly.GetExecutingAssembly().Location + ".msalLogs.txt", sb.ToString());
-            sb.Clear();
+            string logs = $"{level} {message}{Environment.NewLine}";
+            File.AppendAllText(System.Reflection.Assembly.GetExecutingAssembly().Location + ".msalLogs.txt", logs);
         }
     }
 }

active-directory-b2c-wpf/TokenCacheHelper.cs

@@ -35,7 +35,7 @@ public static void AfterAccessNotification(TokenCacheNotificationArgs args)
             {
                 lock (FileLock)
                 {
-                    // reflect changesgs in the persistent store
+                    // reflect changes in the persistent store
                     File.WriteAllBytes(CacheFilePath,
                                        ProtectedData.Protect(args.TokenCache.SerializeMsalV3(),
                                                              null,