Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Update sample to use WAM#47

Open
bgavrilMS wants to merge 1 commit into
msal3xfrom
bogavril/wam
Open

Update sample to use WAM#47
bgavrilMS wants to merge 1 commit into
msal3xfrom
bogavril/wam

Conversation

@bgavrilMS
Copy link
Copy Markdown
Contributor

No description provided.

@bgavrilMS
Copy link
Copy Markdown
Contributor Author

App creation scripts do not work for UWP because you cannot figure out redirect uri.

@jmprieur
Copy link
Copy Markdown
Contributor

@kalyankrishna1 i would like to have your opinion on these changes.
@bgavrilMS I would recommend that:

  • instead of removing the app registration script, we add a manual step
  • We also need to work with the portal team for the UWP quickstart (it will be broken).

Copy link
Copy Markdown
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided recommendations,

Comment thread AppCreationScripts/apps.json Outdated
@@ -1,44 +0,0 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should absolutely not be removed, as it will break the UWP quickstart in the portal.
Please re-add it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our UWP quickstart? :( It hasn't been updated since MSAL 4.25 :(

Comment thread AppCreationScripts/apps.json Outdated
"x-ms-version": "2.0",
"replyUrlsWithType": [
{
"url": "https://login.microsoftonline.com/common/oauth2/nativeclient",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to work with Manoj to have the portal compute the redirect URI of the solution it provides as a zip file.

Comment thread AppCreationScripts/sample.json Outdated
"Comment": "Navigate to the Manifest page and change 'signInAudience' to 'AzureADandPersonalMicrosoftAccount'."
},
{
"Comment": "Navigate to the Manifest page and change 'accessTokenAcceptedVersion' to 2."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right solution. Add a manual step, for instance described with an aka.ms link

private static async Task<string> SignInUserAndGetTokenUsingMSAL(string[] scopes)
{
// returns smth like S-1-15-2-2601115387-131721061-1180486061-1362788748-631273777-3164314714-2766189824
string sid = Windows.Security.Authentication.Web.WebAuthenticationBroker.GetCurrentApplicationCallbackUri().Host.ToUpper();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want the portal to somehow run this code to get the sid ...

.WithUseCorporateNetwork(false)
.WithRedirectUri(DefaultRedirectUri.Value)
.WithBroker(true)
.WithLogging((level, message, containsPii) =>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still needed?

Comment thread README.md Outdated

### Step 2: Register the sample application with your Azure Active Directory tenant

There is one project in this sample. To register it, you can:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this, but provide a manual step.

Comment thread README.md Outdated

1. In `MainPage.XAML.cs`, Update `WithRedirectUri` with `WithDefaultRedirectUri` as shown in below lines of code:

**Current Code**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this part?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants