A Helper utility for the samples#185
Open
SameerK-MSFT wants to merge 11 commits into
Open
Conversation
SameerK-MSFT
requested review from
jennyf19,
jmprieur,
maliksahil,
pmaytak and
trwalke
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
| throw new ArgumentException($"Both doSilent and do Interactive cannot be false"); | ||
| } | ||
| } | ||
| catch (MsalUiRequiredException) |
Contributor
There was a problem hiding this comment.
you need to catch the exception message here, as they are needed for a claims challenge.
jennyf19
reviewed
Dec 24, 2021
jennyf19
reviewed
Dec 24, 2021
Contributor
jennyf19
left a comment
jennyf19
left a comment
There was a problem hiding this comment.
I think this is a great start. Would be nice to align more with the higher-level API we have in Id.Web, as far as method names (ITokenAcquistion, IDownstreamWebApi), to provide consistency.
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check PCAHelper.md for explanation