Skip to content

Add missing encoding #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamelafox merged 3 commits into from
Apr 30, 2025
Merged

Add missing encoding #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf94100
Add missing encoding
pamelafox Apr 29, 2025
0493462
Merge branch 'main' into addencoding
pamelafox Apr 29, 2025
8f738e1
Remove azure-ai-generative
pamelafox Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ description = "Evaluate chat applications using Azure OpenAI evaluators"
dependencies = [
"requests",
"python-dotenv",
"azure-ai-generative[evaluate]==1.0.0b11",
"azure-ai-evaluation==1.5.0",
"marshmallow==3.23.2", # Older version required due to promptflow issue with _T import
"azure-search-documents",
Expand Down
8 changes: 4 additions & 4 deletions src/evaltools/review/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def summarize_results(results_dir):
folders = [f for f in os.listdir(results_dir) if os.path.isdir(os.path.join(results_dir, f))]
folders.sort()
for folder in folders:
with open(Path(results_dir) / folder / "summary.json") as f:
with open(Path(results_dir) / folder / "summary.json", encoding="utf-8") as f:
summary = json.load(f)
run_summaries[folder] = summary
# first find the common parameters across the runs
Expand Down Expand Up @@ -62,10 +62,10 @@ def summarize_results(results_dir):
run_row.append(summary[metric_name][stat])
else:
run_row.append("?")
with open(Path(results_dir) / folder / "eval_results.jsonl") as f:
with open(Path(results_dir) / folder / "eval_results.jsonl", encoding="utf-8") as f:
run_row.append(sum(1 for _ in f))
rows.append(run_row)
with open(Path(results_dir) / folder / "evaluate_parameters.json") as f:
with open(Path(results_dir) / folder / "evaluate_parameters.json", encoding="utf-8") as f:
row_parameters[folder] = json.load(f)

return rows, row_parameters
Expand All @@ -74,7 +74,7 @@ def summarize_results(results_dir):
def diff_directories(directories: list[Path], changed: str | None = None):
data_dicts = []
for directory in directories:
with open(directory / "eval_results.jsonl") as f:
with open(directory / "eval_results.jsonl", encoding="utf-8") as f:
data_json = [json.loads(question_json) for question_json in f.readlines()]
data_dicts.append({question["question"]: question for question in data_json})
if changed:
Expand Down