test,fix: Force pytest to exit zero when no tests are collected#221
Merged
kdestin merged 2 commits intoAzure-Samples:mainfrom Apr 7, 2025
Merged
test,fix: Force pytest to exit zero when no tests are collected#221kdestin merged 2 commits intoAzure-Samples:mainfrom
kdestin merged 2 commits intoAzure-Samples:mainfrom
Conversation
…amples
pytest considers a failure to collect any tests as an error to be
investigated. In the context of "only running pytest tests for
changed samples", we'd expect this to happen somewhat commonly.
This PR makes pytest exit OK when no tests were collected if this
plugin is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pytest considers it an error when pytest is invoked and no tests are collected (pytest-dev/pytest#2393). In the context of our local plugin that filters tests based on the git diff, this behavior is undesirable since it causes CI to fail when a PR doesn't touch a sample.
This PR updates our local plugin to force pytest to exit 0 when no tests are collected and any of the plugin's commandline arguments were provided.
Checklist