Skip to content

fix: add input validation for offset/limit to prevent query injection in CosmosDB #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KhawarHabibKhan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add input validation for offset/limit to prevent query injection in CosmosDB #2146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion code/backend/api/chat_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ async def list_conversations():
return jsonify({"error": "Chat history is not available"}), 400

try:
offset = request.args.get("offset", 0)
try:
offset = int(request.args.get("offset", 0))
except (ValueError, TypeError):
return jsonify({"error": "offset must be a valid integer"}), 400
if offset < 0:
return jsonify({"error": "offset must be non-negative"}), 400
authenticated_user = get_authenticated_user_details(
request_headers=request.headers
)
Expand Down
4 changes: 4 additions & 0 deletions code/backend/batch/utilities/chat_history/cosmosdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,12 @@ async def delete_messages(self, conversation_id, user_id):

async def get_conversations(self, user_id, limit, sort_order="DESC", offset=0):
parameters = [{"name": "@userId", "value": user_id}]
if sort_order not in ("ASC", "DESC"):
sort_order = "DESC"
query = f"SELECT * FROM c where c.userId = @userId and c.type='conversation' order by c.updatedAt {sort_order}"
if limit is not None:
offset = int(offset)
limit = int(limit)
query += f" offset {offset} limit {limit}"

conversations = []
Expand Down