Skip to content

Commit d2d3e2b

Browse files
Merge pull request #4854 from Azure/dependabot/github_actions/golangci/golangci-lint-action-9.2.1
Bump golangci/golangci-lint-action from 9.2.0 to 9.2.1
2 parents 53449aa + c1e250f commit d2d3e2b

2 files changed

Lines changed: 22 additions & 1 deletion

File tree

.github/workflows/ci-go.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ jobs:
7676
with:
7777
go-version-file: go.mod
7878
- name: Run golangci-lint
79-
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
79+
uses: golangci/golangci-lint-action@82606bf257cbaff209d206a39f5134f0cfbfd2ee # v9.2.1
8080
with:
8181
version: v2.8.0
8282
args: -v --timeout 15m

test/e2e/adminapi_etcdkeycount.go

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
. "github.com/onsi/ginkgo/v2"
1717
. "github.com/onsi/gomega"
1818

19+
corev1 "k8s.io/api/core/v1"
1920
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2021
)
2122

@@ -36,6 +37,26 @@ var _ = Describe("[Admin API] ETCD key count action", func() {
3637
)
3738
Expect(nodes.Items).NotTo(BeEmpty(), "expected at least one master node")
3839
vmName := nodes.Items[0].Name
40+
podName := "etcd-" + vmName
41+
42+
By("verifying the etcd pod is ready before attempting to exec")
43+
Eventually(func(g Gomega, ctx context.Context) {
44+
pod := GetK8sObjectWithRetry(
45+
ctx, clients.Kubernetes.CoreV1().Pods("openshift-etcd").Get, podName, metav1.GetOptions{},
46+
)
47+
g.Expect(pod.Status.Phase).To(Equal(corev1.PodRunning),
48+
"pod %s phase: expected Running, got %s", podName, pod.Status.Phase)
49+
// Verify pod is actually ready (not just Running)
50+
for _, cond := range pod.Status.Conditions {
51+
if cond.Type == corev1.PodReady {
52+
g.Expect(cond.Status).To(Equal(corev1.ConditionTrue),
53+
"pod %s Ready condition: expected True, got %s", podName, cond.Status)
54+
return
55+
}
56+
}
57+
g.Expect(false).To(BeTrue(), "pod %s has no Ready condition", podName)
58+
}).WithContext(ctx).WithTimeout(DefaultEventuallyTimeout).Should(Succeed(),
59+
"etcd pod %s not ready within timeout", podName)
3960

4061
By("calling the etcdkeycount admin API with vmName=" + vmName)
4162
params := url.Values{"vmName": []string{vmName}}

0 commit comments

Comments
 (0)