small stuff, copilot suggestions

Author: mrWinston

Makefile

@@ -9,7 +9,7 @@ COMMIT = $(shell git rev-parse --short=7 HEAD)$(shell [[ $$(git status --porcela
 ARO_IMAGE_BASE = ${RP_IMAGE_ACR}.azurecr.io/aro
 E2E_FLAGS ?= -test.v --ginkgo.vv --ginkgo.timeout 180m --ginkgo.flake-attempts=2 --ginkgo.junit-report=e2e-report.xml
 E2E_LABEL ?= !smoke&&!regressiontest
-E2E_FOKUS ?= *
+E2E_FOKUS ?=
 GO_FLAGS ?= -tags=containers_image_openpgp,exclude_graphdriver_btrfs,exclude_graphdriver_devicemapper
 OC ?= oc
 

test/e2e/adminapi_resize_controlplane.go

@@ -42,8 +42,8 @@ func getControlPlaneVMs(ctx context.Context) []compute.VirtualMachine {
 	clusterResourceGroup := stringutils.LastTokenByte(*oc.ClusterProfile.ResourceGroupID, '/')
 	vms, err := clients.VirtualMachines.List(ctx, clusterResourceGroup)
 	Expect(err).NotTo(HaveOccurred())
-
 	return slices.DeleteFunc(vms, func(vm compute.VirtualMachine) bool {
+		Expect(vm.Name).ToNot(BeNil())
 		return !strings.Contains(*vm.Name, "master")
 	})
 }
@@ -54,6 +54,7 @@ func getControlPlaneVMs(ctx context.Context) []compute.VirtualMachine {
 func getControlPlaneVMSize(ctx context.Context) string {
 	vms := getControlPlaneVMs(ctx)
 	Expect(vms).NotTo(BeEmpty())
+	Expect(vms[0].HardwareProfile).NotTo(BeNil())
 	return string(vms[0].HardwareProfile.VMSize)
 }
 
@@ -198,7 +199,7 @@ var _ = Describe("[Admin API] Resize control plane", func() {
 		} else if strings.HasPrefix(preResizeVMSize, "Standard_E") {
 			targetSku = strings.Replace(preResizeVMSize, "Standard_E", "Standard_D", 1)
 		} else {
-			Skip(fmt.Sprintf("Cowardly refusing to resize the cluster, only know how to hande E and D vms, this cluster has: %s", preResizeVMSize))
+			Skip(fmt.Sprintf("Cowardly refusing to resize the cluster, only know how to handle E and D vms, this cluster has: %s", preResizeVMSize))
 		}
 
 		By(fmt.Sprintf("Resizing from %s to %s", preResizeVMSize, targetSku))
@@ -225,7 +226,7 @@ var _ = Describe("[Admin API] Resize control plane", func() {
 			Expect(vm.HardwareProfile).ToNot(BeNil())
 			Expect(string(vm.HardwareProfile.VMSize)).To(Equal(targetSku))
 			Expect(vm.ProvisioningState).ToNot(BeNil())
-			Expect(*vm.ProvisioningState).ToNot(Equal(string(compute.ProvisioningStateSucceeded)))
+			Expect(*vm.ProvisioningState).To(Equal(string(compute.ProvisioningStateSucceeded)))
 		}
 
 		By("Validating machine and node labels")