chore(cli): improve tag description#4883
Merged
Merged
Conversation
komidore64
requested review from
alcasim,
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
kevinobriendotca,
kimorris27,
mociarain,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
tuxerrante,
ventifus,
wanghaoran1988 and
yjst2012
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure CLI ARO extension’s aro create argument metadata to clarify how --tags behave, aiming to reduce confusion about whether tags apply to the resource group or just the created cluster resource.
Changes:
- Adds custom help text for the
--tagsargument inaro create. - Attempts to append the default
tags_typehelp text to the new clarification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+49
| c.argument('tags', | ||
| tags_type) | ||
| tags_type, | ||
| help='Tag an individual resource. ' + tags_type.settings.get('help', '')) |
There was some confusion whether a tag attaches to a single resource or attaches to the resourcegroup and therefore every resource underneath it. Co-authored-by: Caden Marchese <cmarches@redhat.com> Ref: https://redhat.atlassian.net/browse/ARO-27517
komidore64
force-pushed
the
adprice/aro-27517-tags-help
branch
from
02ef1e7 to
7f49556
Compare
kimorris27
approved these changes
Jun 11, 2026
Contributor
|
Merging - no need to wait on CI for a CLI change, especially a help text fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was some confusion whether a tag attaches to a single resource or attaches to the resourcegroup and therefore every resource underneath it.
Which issue this PR addresses:
Fixes https://redhat.atlassian.net/browse/ARO-27517
What this PR does / why we need it:
Additional help text
Test plan for issue:
View the help text with
az aro create --helpIs there any documentation that needs to be updated for this PR?
No.
How do you know this will function as expected in production?
It's just help text.