Use SHARED_MIWI_CLUSTER_VERSION env for cluster version#4885
Merged
Conversation
slawande2
requested review from
alcasim,
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
kevinobriendotca,
kimorris27,
mociarain,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
tuxerrante,
ventifus,
wanghaoran1988 and
yjst2012
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared MIWI cluster creation script to avoid hardcoding the OpenShift cluster version, instead sourcing it from an environment variable so the version can be controlled externally (e.g., per environment/run) without editing the script.
Changes:
- Adds
SHARED_MIWI_CLUSTER_VERSIONas a required environment variable. - Uses
SHARED_MIWI_CLUSTER_VERSIONfor theaz aro create --versionargument (replacing the hardcoded4.15.35).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slawande2
force-pushed
the
slawande/add-version-env
branch
from
7b428c9 to
09749cd
Compare
slawande2
added
chainsaw
kimorris27
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replaces hardcoded cluster version (
4.15.35) in shared MIWI cluster creation with theSHARED_MIWI_CLUSTER_VERSIONenvironment variable