[ARO-26365, ARO-26372] Add CredScan suppressions for false positives#4911
Open
LiniSusan wants to merge 3 commits into
Open
[ARO-26365, ARO-26372] Add CredScan suppressions for false positives#4911LiniSusan wants to merge 3 commits into
LiniSusan wants to merge 3 commits into
Conversation
LiniSusan
requested review from
alcasim,
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
kevinobriendotca,
kimorris27,
mociarain,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
tuxerrante,
ventifus,
wanghaoran1988 and
yjst2012
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CredScan suppressions list to silence two reported CSCAN-GENERAL0060 findings that are believed to be false positives (a test error message mentioning username:password, and an upstream Docker API spec example).
Changes:
- Add a CredScan suppression entry for an
extract_test.gocredential-format string false positive. - Add a CredScan suppression entry for a vendored Docker
swagger.yamlfalse positive.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+59
| { | ||
| "file": "extract_test.go", | ||
| "_justification": "test assertion matching expected error message text containing username:password format description, not a real credential" | ||
| }, |
Comment on lines
+60
to
+62
| { | ||
| "file": "vendor/github.com/docker/docker/api/swagger.yaml", | ||
| "_justification": "vendored upstream Docker API spec - example schema values, not real credentials" |
Suppress two CSCAN-GENERAL0060 false positives: - extract_test.go: test assertion containing "username:password" as error message text, not a real credential - vendor/github.com/docker/docker/api/swagger.yaml: vendored upstream Docker API spec with example schema values, not real credentials Co-authored-by: Cursor <cursoragent@cursor.com>
Update suppression entry from bare filename to correct relative path pkg/util/pullsecret/extract_test.go so CredScan can match it. Co-authored-by: Cursor <cursoragent@cursor.com>
LiniSusan
force-pushed
the
linisusan/ARO-26365-aro-26372-credscan-suppress-false-positives
branch
from
323670e to
c668ad3
Compare
Use neutral pullsecret error wording to avoid password-pattern matches and align the existing docker swagger suppression to CSCAN-GENERAL0060. Co-authored-by: Cursor <cursoragent@cursor.com>
Comment on lines
+61
to
+62
| "file": "vendor/github.com/docker/docker/api/swagger.yaml", | ||
| "_justification": "vendored upstream Docker API spec - example schema values, not real credentials" |
Comment on lines
+55
to
63
| }, | ||
| { | ||
| "file": "pkg/util/pullsecret/extract_test.go", | ||
| "_justification": "test assertion matching expected error message text containing username:password format description, not a real credential" | ||
| }, | ||
| { | ||
| "file": "vendor/github.com/docker/docker/api/swagger.yaml", | ||
| "_justification": "vendored upstream Docker API spec - example schema values, not real credentials" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://redhat.atlassian.net/browse/ARO-26365
https://redhat.atlassian.net/browse/ARO-26372
Fixes
Suppress two CSCAN-GENERAL0060 false positives:
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?