Skip to content

Commit 0af3ae2

Browse files
authored
fix: widen fs.file-max sysctl from int32 to int64 (#8640)
Sets the right data type(int64) for fs.file-max sysctl parameter, matching the Linux kernel default that customers already see at runtime. Also matches the documentation here: https://learn.microsoft.com/en-us/azure/aks/custom-node-configuration?tabs=linux-node-pools
1 parent f927481 commit 0af3ae2

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

aks-node-controller/proto/aksnodeconfig/v1/custom_linux_os_config.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ message SysctlConfig {
4949
optional int32 net_netfilter_nf_conntrack_max = 19;
5050
optional int32 net_netfilter_nf_conntrack_buckets = 20;
5151
optional int32 fs_inotify_max_user_watches = 21;
52-
optional int32 fs_file_max = 22;
52+
optional int64 fs_file_max = 22;
5353
optional int32 fs_aio_max_nr = 23;
5454
optional int32 fs_nr_open = 24;
5555
optional int32 kernel_threads_max = 25;

pkg/agent/datamodel/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,7 @@ type SysctlConfig struct {
800800
NetNetfilterNfConntrackMax *int32 `json:"netNetfilterNfConntrackMax,omitempty"`
801801
NetNetfilterNfConntrackBuckets *int32 `json:"netNetfilterNfConntrackBuckets,omitempty"`
802802
FsInotifyMaxUserWatches *int32 `json:"fsInotifyMaxUserWatches,omitempty"`
803-
FsFileMax *int32 `json:"fsFileMax,omitempty"`
803+
FsFileMax *int64 `json:"fsFileMax,omitempty"`
804804
FsAioMaxNr *int32 `json:"fsAioMaxNr,omitempty"`
805805
FsNrOpen *int32 `json:"fsNrOpen,omitempty"`
806806
KernelThreadsMax *int32 `json:"kernelThreadsMax,omitempty"`

0 commit comments

Comments
 (0)