fix: move apt_get_download to Ubuntu-specific script file

Flatcar is breaking the OSProfile limit again, so savings need to be
made somewhere. This helper function is only used in that one file.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>

Author: chewi

parts/linux/cloud-init/artifacts/cse_helpers.sh

@@ -564,32 +564,6 @@ semverCompare() {
     return 1
 }
 
-
-
-apt_get_download() {
-  retries=$1; wait_sleep=$2; shift && shift;
-  local ret=0
-  pushd $APT_CACHE_DIR || return 1
-  for i in $(seq 1 "$retries"); do
-    dpkg --configure -a --force-confdef
-    wait_for_apt_locks
-
-    # Pull the first quoted URL from --print-uris
-    url="$(apt-get --print-uris -o Dpkg::Options::=--force-confold download -y -- "$@" \
-           | awk -F"'" 'NR==1 && $2 {print $2}')"
-    if [ -n "$url" ]; then
-      # This avoids issues with the naming in the package. `apt-get download`
-      # encodes the package names with special characters and does not decode
-      # them when saving to disk, but `curl -J` handles the names correctly.
-      if curl -fLJO -- "$url"; then ret=0; break; fi
-    fi
-
-    if [ "$i" -eq "$retries" ]; then ret=1; else sleep "$wait_sleep"; fi
-  done
-  popd || return 1
-  return "$ret"
-}
-
 getCPUArch() {
     arch=$(uname -m)
     # shellcheck disable=SC3010

parts/linux/cloud-init/artifacts/ubuntu/cse_install_ubuntu.sh

@@ -1,5 +1,29 @@
 #!/bin/bash
 
+apt_get_download() {
+  retries=$1; wait_sleep=$2; shift && shift;
+  local ret=0
+  pushd $APT_CACHE_DIR || return 1
+  for i in $(seq 1 "$retries"); do
+    dpkg --configure -a --force-confdef
+    wait_for_apt_locks
+
+    # Pull the first quoted URL from --print-uris
+    url="$(apt-get --print-uris -o Dpkg::Options::=--force-confold download -y -- "$@" \
+           | awk -F"'" 'NR==1 && $2 {print $2}')"
+    if [ -n "$url" ]; then
+      # This avoids issues with the naming in the package. `apt-get download`
+      # encodes the package names with special characters and does not decode
+      # them when saving to disk, but `curl -J` handles the names correctly.
+      if curl -fLJO -- "$url"; then ret=0; break; fi
+    fi
+
+    if [ "$i" -eq "$retries" ]; then ret=1; else sleep "$wait_sleep"; fi
+  done
+  popd || return 1
+  return "$ret"
+}
+
 removeContainerd() {
     apt_get_purge 10 5 300 moby-containerd
 }