Skip to content

Commit db88664

Browse files
authored
fix: copilot instructions for windows (#8013)
1 parent 0547cb3 commit db88664

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/copilot-instructions.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,13 @@ Analyze PRs for these compatibility scenarios:
117117

118118
**2. Windows Bidirectional Compatibility**
119119
- **Context**: Windows VHD and CSE scripts release on different cadences with no guaranteed order
120-
- **What to check**: Changes to `staging/cse/windows/` (CSE scripts) or `vhdbuilder/packer/windows/` (VHD scripts)
120+
- **What to check**: Changes to `staging/cse/windows/` (CSE scripts) or `vhdbuilder/packer/windows/` (VHD scripts).
121121
- **Breaking signals**:
122-
- New CSE scripts assuming capabilities that old VHDs don't have
123-
- New VHD scripts expecting features that old CSE versions don't provide
122+
- New CSE scripts using features in the VHD Scripts that aren't present before this PR.
123+
- New VHD scripts expecting features in the CSE scripts that aren't present before this PR.
124124
- Changes to shared state (registry keys, files, environment variables) that break coordination
125125
- Removing PowerShell functions or cmdlets that the other component might call
126+
- Incompatibilities between newer versions of the CSE scripts and older versions of the VHD scripts are critical to detect as they can cause production outages.
126127

127128
**3. aks-node-controller Migration (Dual-Mode Support)**
128129
- **Context**: Transitioning from uploading scripts during both VHD build and CSE to only uploading aks-node-controller during VHD build

0 commit comments

Comments
 (0)