feat: consume NI kubernetes packages on MAR#7134
Merged
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
changed the title
…_oras call Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
15ebeb2 to
96362ac
Compare
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
96362ac to
debed3f
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
debed3f to
1f3b774
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
1f3b774 to
a7d6e32
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
a7d6e32 to
5ac09f3
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
5ac09f3 to
6457bb7
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
6457bb7 to
f6eac4f
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
f6eac4f to
df38000
Compare
fseldow
reviewed
Oct 13, 2025
| if [ "$i" -gt 1 ]; then | ||
| sleep $wait_sleep | ||
| fi | ||
| timeout 60 oras pull $url -o $target_folder --registry-config ${ORAS_REGISTRY_CONFIG_FILE} $extra_flags > $ORAS_OUTPUT 2>&1 |
Contributor
There was a problem hiding this comment.
- timeout 60 oras pull privateace2enonanonpullwestus3.azurecr.io/aks/packages/kubernetes/kubelet:v1.32.7 -o /tmp/kubernetes/downloads/kubelet --registry-config /etc/oras/config.yaml '"--platform=linux/amd64:ubuntu' '22.04"'
- '[' 1 -eq 0 ']'
- cat /tmp/oras_verbose.out
Error: "oras pull" requires exactly 1 argument but got 3
Usage: oras pull [flags] {:|@}
Please specify exactly 1 argument as the artifact reference you want to pull. Run "oras pull -h" for more options and examples
Contributor
Author
There was a problem hiding this comment.
Seems $* is buggy, let's switch back to $@. I will add unit test coverage for it.
fseldow
reviewed
Oct 13, 2025
fseldow
reviewed
Oct 13, 2025
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
9a59747 to
6004bc4
Compare
qweeah
force-pushed
the
qweeah/install-ni-pkg
branch
from
6004bc4 to
e6f4862
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
fseldow
reviewed
Oct 15, 2025
fseldow
reviewed
Oct 15, 2025
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
fseldow
approved these changes
Oct 15, 2025
fseldow
reviewed
Oct 15, 2025
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Devinwong
reviewed
Oct 15, 2025
fseldow
approved these changes
Oct 16, 2025
Collaborator
|
The master branch updated with new customData files. So unfortunately you will need to rebase/merge with master, resolve the conflicts (just accepting all incoming should be fine), and then do |
Devinwong
approved these changes
Oct 16, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR consumes Network-Isolated packages kubelet and kubectl binaries on MAR. Current implementation only covers Ubuntu scenario.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: