fix: SSH not disabled issue on AzureLinux and add E2E to guard#7190
Merged
fix: SSH not disabled issue on AzureLinux and add E2E to guard#7190
Conversation
norshtein
requested review from
AbelHu,
Devinwong,
anujmaheshwari1,
bravebeaver,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Member
Author
|
All newly added E2E succeeded: ✓ AzureLinuxV2 disable SSH (144.44s) |
invidian
reviewed
Oct 14, 2025
| BootstrapConfigMutator: func(nbc *datamodel.NodeBootstrappingConfiguration) { | ||
| nbc.SSHStatus = datamodel.SSHOff | ||
| }, | ||
| SkipSSHConnectivityValidation: true, // Skip SSH connectivity validation since SSH is down |
Contributor
There was a problem hiding this comment.
we should probably adapt our default validation to work with run command as well so we don't have to skip it in these scenarios, that's another PR though
cameronmeissner
approved these changes
Oct 14, 2025
cameronmeissner
changed the title
Member
Author
|
Hey @cameronmeissner , I've merged master in order to resolve conflict, could you help reapprove the PR? Thanks! |
awesomenix
approved these changes
Oct 15, 2025
Member
Author
|
Thanks @cameronmeissner and @awesomenix for reviewing and approving! I'll merge the PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR fix an issue that SSH daemon is not correctly disabled on AzureLinux when
SSHStatusis set tooff.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: