fix: ubuntu 2004 doesnt support 1.35, use 1.34#8828
Open
awesomenix wants to merge 1 commit into
Open
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
xuexu6666 and
zachary-bailey
as code owners
awesomenix
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates AgentBaker E2E scenario tests to pin several Ubuntu 2204 scenarios to a specific Kubernetes patch version (1.34.8), instead of relying on the cluster’s default/latest Kubernetes version.
Changes:
- Pin
Test_Ubuntu2204_EntraIDSSH_Scriptlessto Kubernetes1.34.8viaOrchestratorProfile.OrchestratorVersion. - Update the Ubuntu 2204 Gen2 ServiceAccountImagePullProfile identity-binding scenarios to enforce
1.34.8(including the scriptless variants’aksConfig.KubernetesVersion).
awesomenix
force-pushed
the
nishp/more/e2efixes
branch
from
3c67f91 to
6b8a64c
Compare
awesomenix
force-pushed
the
nishp/more/e2efixes
branch
from
6b8a64c to
2a2364e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
e2e/config/vhd.go:77
VHDUbuntu2004FIPSContainerd(Gen1) was removed from the E2E VHD catalog, butAKSUbuntuFipsContainerd2004still looks like a maintained SIG distro (seepkg/agent/datamodel/sig_config.goubuntu image map and thebuild2004fipscontainerdpipeline parameter/job). If Gen1 is still built/maintained, keeping an E2E Image entry for it helps preserve coverage; if it’s being deprecated, the distro/pipeline definitions likely need a coordinated cleanup in a separate change.
VHDUbuntu2004FIPSGen2Containerd = &Image{
Name: "2004gen2fipscontainerd",
OS: OSUbuntu,
Arch: "amd64",
Distro: datamodel.AKSUbuntuFipsContainerd2004Gen2,
| @@ -838,33 +838,14 @@ func Test_Ubuntu2204FIPS(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the title says force use 1.34 for ubuntu 2004 fips