Fix Multi LB Config Name Validation (#100)

* remove IP conversion warnings

* remove unnecessary update when no NAT pools

* add and fix nat scenarios

* fixed as rg dependency

* renamed backup module

* added nat pool migration function

* support for nat rule only configs

* comment clarity

* nat pool migration with emtpy backend

* nat rule ipconfig migration

* nat pool migration validation and param changes

* remove vmss from scenario validation

* add NVA to outbound options

* remove resource graph module check

* move to single line error message

* added Learn doc link

* fix multi lb name validation

* version bump

Author: mbrat2005

AzureBasicLoadBalancerUpgrade/README.md

@@ -1,5 +1,7 @@
 # Upgrade a basic load balancer with PowerShell
 
+[**Microsoft Learn Documentation**](https://learn.microsoft.com/azure/load-balancer/upgrade-basic-standard-with-powershell)
+
 >[!Important]
 >On September 30, 2025, Basic Load Balancer will be retired. For more information, see the [official announcement](https://azure.microsoft.com/updates/azure-basic-load-balancer-will-be-retired-on-30-september-2025-upgrade-to-standard-load-balancer/). If you are currently using Basic Load Balancer, make sure to upgrade to Standard Load Balancer prior to the retirement date. 
 

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/AzureBasicLoadBalancerUpgrade.psd1

@@ -12,7 +12,7 @@
     RootModule = 'AzureBasicLoadBalancerUpgrade'
 
     # Version number of this module.
-    ModuleVersion = '2.4.0'
+    ModuleVersion = '2.4.1'
 
     # Supported PSEditions
     # CompatiblePSEditions = @()
@@ -107,7 +107,7 @@
             # IconUri = ''
 
             # ReleaseNotes of this module
-            ReleaseNotes = 'Fix NAT Rule backend migration, Add NAT Pool to NAT Rule migration'
+            ReleaseNotes = 'Fix multi-LB name validation'
 
             # Prerelease string of this module
             # Prerelease = ''

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/modules/Start-AzBasicLoadBalancerUpgrade/Start-AzBasicLoadBalancerUpgrade.psm1

@@ -248,11 +248,7 @@ function Start-AzBasicLoadBalancerUpgrade {
         }
     }
     catch {
-        $message = @"
-            [Start-AzBasicLoadBalancerUpgrade] Failed to find basic load balancer '$BasicLoadBalancerName' in resource group '$ResourceGroupName' under subscription
-            '$((Get-AzContext).Subscription.Name)'. Ensure that the correct subscription is selected and verify the load balancer and resource group names.
-            Error text: $_
-"@
+        $message = "[Start-AzBasicLoadBalancerUpgrade] Failed to find basic load balancer '$BasicLoadBalancerName' in resource group '$ResourceGroupName' under subscription '$((Get-AzContext).Subscription.Name)'. Ensure that the correct subscription is selected and verify the load balancer and resource group names. Error text: $_"
         log -severity Error -message $message -terminateOnError
     }
 
@@ -289,11 +285,10 @@ function Start-AzBasicLoadBalancerUpgrade {
     ElseIf ($PSCmdlet.ParameterSetName -eq 'MultiLB') {
         log -Message "[Start-AzBasicLoadBalancerUpgrade] -MultiLBConfig parameter set detected, validating scenarios for multiple load balancers"
 
-        # verify the scenario for multi-load balancer configurations
-        Test-SupportedMultiLBScenario -MultiLBConfig $multiLBConfig
-
         # verify scenario for each load balancer in the multiLBConfig array
         ForEach ($LBConfig in $multiLBConfig) {
+            
+            # set standard LB name if none is specified
             if (![string]::IsNullOrEmpty($LBConfig.standardLoadBalancerName)) {
                 $StdLoadBalancerName = $LBConfig.standardLoadBalancerName
             }
@@ -310,6 +305,9 @@ function Start-AzBasicLoadBalancerUpgrade {
             # add the evaluated scenario details to the LBConfig object
             $LBConfig['scenario'] = $scenario
         }
+
+        # verify the scenario for multi-load balancer configurations
+        Test-SupportedMultiLBScenario -MultiLBConfig $multiLBConfig
 
         if ($validateScenarioOnly) {
             log -Message "[Start-AzBasicLoadBalancerUpgrade] Scenario validation completed, exiting because -validateScenarioOnly was specified"
@@ -366,6 +364,8 @@ function Start-AzBasicLoadBalancerUpgrade {
                 }
             }
             'VMSS' {
+                $standardScenarioParams += @{skipMigrateNATPoolsToNATRules = $skipMigrateNATPoolsToNATRules.IsPresent}
+
                 switch ($migrationConfig.scenario.ExternalOrInternal) {
                     'internal' {
                         if ((!$PSBoundParameters.ContainsKey("FailedMigrationRetryFilePathLB"))) {

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/modules/ValidateScenario/ValidateScenario.psm1

@@ -225,11 +225,7 @@ Function Test-SupportedMigrationScenario {
 
         ForEach ($instance in $vmssInstances) {
             If ($instance.ProtectionPolicy.ProtectFromScaleSetActions) {
-                $message = @"
-                [Test-SupportedMigrationScenario] VMSS '$($vmss.Name)' contains 1 or more instances with a ProtectFromScaleSetActions Instance Protection configured. This
-                module cannot upgrade the associated load balancer because a VMSS cannot be a backend member of both basic and standard SKU load balancers. Remove the Instance
-                Protection policy and re-run the module.
-"@
+                $message = "[Test-SupportedMigrationScenario] VMSS '$($vmss.Name)' contains 1 or more instances with a ProtectFromScaleSetActions Instance Protection configured. This module cannot upgrade the associated load balancer because a VMSS cannot be a backend member of both basic and standard SKU load balancers. Remove the Instance Protection policy and re-run the module."
                 log -Severity 'Error'
                 $vmssInstances.Remove($instance)
             }
@@ -490,7 +486,7 @@ Function Test-SupportedMigrationScenario {
             $message = "[Test-SupportedMigrationScenario] Internal load balancer backend VMs do not have Public IPs and will not have outbound internet connectivity after migration to a Standard LB."
             log -Message $message -Severity 'Warning'
 
-            Write-Host "In order for your VMs to access the internet, you'll need to take additional action post-migration. Either add Public IPs to each VM or assign a NAT Gateway to the VM subnet (see: https://learn.microsoft.com/en-us/azure/virtual-network/ip-services/default-outbound-access)." -ForegroundColor Yellow
+            Write-Host "In order for your VMs to access the internet, you'll need to take additional action before or after migration. Either add Public IPs to each VM, assign a NAT Gateway to the VM subnet, or route internet traffic through an NVA (see: https://learn.microsoft.com/en-us/azure/virtual-network/ip-services/default-outbound-access)." -ForegroundColor Yellow
             If (!$force.IsPresent) {
                 $response = $null
                 while ($response -ne 'y' -and $response -ne 'n') {
@@ -508,49 +504,6 @@ Function Test-SupportedMigrationScenario {
         }
     }
 
-    # check that Az.ResourceGraph module is installed for VM migrations
-    If ($scenario.BackendType -eq 'VM' -and !(Get-Module -Name Az.ResourceGraph -ListAvailable)) {
-        $message = "[Test-SupportedMigrationScenario] Migrating Load Balancers with VM backends requires the Az.ResourceGraph module, but the module was not found."
-        log -Message $message -Severity 'Warning'
-
-        If (!$force.IsPresent) {
-            Write-Host "Migrating Load Balancers with VM backends requires the Az.ResourceGraph module, but the module was not found to be installed." -ForegroundColor Yellow
-            $response = $null
-            while ($response -ine 'y' -and $response -ine 'n') {
-                $response = Read-Host -Prompt "Do you want the script to install the Az.ResourceGraph module for the current user? (y/n)"
-            }
-            If ($response -ieq 'n') {
-                $message = "[Test-SupportedMigrationScenario] User chose to exit the module"
-                log -Message $message -Severity 'Error' -terminateOnError
-            }
-        }
-
-        If ($response -ieq 'y' -or $force.IsPresent) {
-
-            Write-Host "Installing the Az.ResourceGraph module in the CurrentUser scope..."
-
-            $message = "[Test-SupportedMigrationScenario] Installing the Az.ResourceGraph module in the CurrentUser scope..."
-            log -Message $message
-            
-            try {
-                $ErrorActionPreference = 'Stop'
-                Install-Module -Name Az.ResourceGraph -Scope CurrentUser -Force
-            }
-            catch {
-                $message = "[Test-SupportedMigrationScenario] Failed to install the Az.ResourceGraph module. Please install manually and re-run the script."
-                log -Message $message -Severity 'Error' -terminateOnError
-            }
-
-            Write-Host "Installing the Az.ResourceGraph module completed successfully."
-
-            $message = "[Test-SupportedMigrationScenario] Installing the Az.ResourceGraph module completed successfully."
-            log -Message $message
-        }
-    }
-    Else {
-        $message = "[Test-SupportedMigrationScenario] The Az.ResourceGraph module is already installed..."
-        log -Message $message
-    }
 
     # if the basic lb is external and has multiple backend pools, warn that the migration will not create a default outbound rule
     If ($scenario.ExternalOrInternal -eq 'External' -and $BasicLoadBalancer.BackendAddressPools.Count -gt 1 -and 
@@ -578,7 +531,7 @@ Function Test-SupportedMigrationScenario {
         }
     }
 
-    Write-Progress -Status "Finished VMSS backend scenario validation" -PercentComplete 100 @progressParams
+    Write-Progress -Status "Finished scenario validation" -PercentComplete 100 @progressParams
 
     log -Message "[Test-SupportedMigrationScenario] Detected migration scenario: $($scenario | ConvertTo-Json -Depth 10 -Compress)"
     log -Message "[Test-SupportedMigrationScenario] Load Balancer '$($BasicLoadBalancer.Name)' is valid for migration"
@@ -597,11 +550,24 @@ Function Test-SupportedMultiLBScenario {
     # check that standard load balancer names are different if basic load balancers are in the same resource group
     log -Message "[Test-SupportedMultiLBScenario] Checking that standard load balancer names are different if basic load balancers are in the same resource group"
 
+    # check standard load balancer names will be unique in the same resource group
     ForEach ($config in $multiLBConfig) {
         $matchingConfigs = @()
-        $matchingConfigs += $multiLBConfig | Where-Object { $_.StandardLoadBalancerName -eq $config.StandardLoadBalancerName -and $_.BasicLoadBalancer.ResourceGroupName -eq $config.BasicLoadBalancer.ResourceGroupName }
+
+        If ([string]::IsNullOrEmpty) {
+            $StdLoadBalancerName = $config.BasicLoadBalancer.Name
+        }
+        Else {
+            $StdLoadBalancerName = $config.StandardLoadBalancerName
+        }
+
+        $matchingConfigs += $multiLBConfig | Where-Object { 
+            (([string]::IsNullOrEmpty($_.StandardLoadBalancerName) -and $_.BasicLoadBalancer.Name -eq $StdLoadBalancerName) -or
+            ($_.StandardLoadBalancerName -eq $StdLoadBalancerName)) -and
+            ($_.BasicLoadBalancer.ResourceGroupName -eq $config.BasicLoadBalancer.ResourceGroupName) }
+
         If ($matchingConfigs.count -gt 1) {
-            log -Severity Error -Message "[Test-SupportedMultiLBScenario] Standard Load Balancer name '$($config.StandardLoadBalancerName)' is used more than once in resource group '$($config.BasicLoadBalancer.ResourceGroupName)'. Standard Load Balancer names must be unique in the same resource group." -terminateOnError
+            log -Severity Error -Message "[Test-SupportedMultiLBScenario] Standard Load Balancer name '$($StdLoadBalancerName)' will be used more than once in resource group '$($config.BasicLoadBalancer.ResourceGroupName)'. Standard Load Balancer names must be unique in the same resource group. If renaming load balancers with the -standardLoadBalancerName parameter, make sure new names are unique." -terminateOnError
         }
     }