Skip to content

fix: bug #698#699

Closed
davenewman777 wants to merge 0 commit into
Azure:mainfrom
davenewman777:main
Closed

fix: bug #698#699
davenewman777 wants to merge 0 commit into
Azure:mainfrom
davenewman777:main

Conversation

@davenewman777
Copy link
Copy Markdown
Contributor

@davenewman777 davenewman777 commented Apr 2, 2025

Overview/Summary

editing query to account for Zone Aligned configurations
Current query only supports Zone Spanning.

Related Issues/Work Items

#698

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Copilot AI review requested due to automatic review settings April 2, 2025 20:28
@davenewman777 davenewman777 requested a review from a team as a code owner April 2, 2025 20:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates an Azure Resource Graph query to support both Zone Spanning and Zone Aligned configurations for AKS clusters. The changes update the filtering condition to exclude clusters with any availability zones enabled and modify the comment to reflect the new behavior.

  • Updated the inline documentation to clarify the query purpose.
  • Changed the filter condition from "numOfAvailabilityZones < 2" to "numOfAvailabilityZones < 1" to capture clusters with no availability zones.
Comments suppressed due to low confidence (1)

azure-resources/ContainerService/managedClusters/kql/4f63619f-5001-439c-bacb-8de891287727.kql:10

  • Confirm that changing the filter from 'numOfAvailabilityZones < 2' to '< 1' accurately captures the intended logic for Zone Aligned configurations, ensuring that clusters with exactly one zone are treated as valid.
| where numOfAvailabilityZones < 1

@davenewman777 davenewman777 changed the title Update 4f63619f-5001-439c-bacb-8de891287727.kql bug fix #698 Apr 2, 2025
@davenewman777 davenewman777 changed the title bug fix #698 fix: bug #698 Apr 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Bug 🐞 Something isn't working label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants