fix: bug #698#699
Closed
davenewman777 wants to merge 0 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates an Azure Resource Graph query to support both Zone Spanning and Zone Aligned configurations for AKS clusters. The changes update the filtering condition to exclude clusters with any availability zones enabled and modify the comment to reflect the new behavior.
- Updated the inline documentation to clarify the query purpose.
- Changed the filter condition from "numOfAvailabilityZones < 2" to "numOfAvailabilityZones < 1" to capture clusters with no availability zones.
Comments suppressed due to low confidence (1)
azure-resources/ContainerService/managedClusters/kql/4f63619f-5001-439c-bacb-8de891287727.kql:10
- Confirm that changing the filter from 'numOfAvailabilityZones < 2' to '< 1' accurately captures the intended logic for Zone Aligned configurations, ensuring that clusters with exactly one zone are treated as valid.
| where numOfAvailabilityZones < 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
editing query to account for Zone Aligned configurations
Current query only supports Zone Spanning.
Related Issues/Work Items
#698
Breaking Changes
As part of this pull request I have
mainbranch