feat: update resource types to align with resource type of resource id#700
Merged
Conversation
Co-authored-by: ejhenry <erhenry@microsoft.com>
change Microsoft.RecoveryServices/vaults to Microsoft.Compute/virtualMachines
Co-authored-by: ejhenry <erhenry@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the recommendation YAML files and related KQL queries to align the resource types with the resource ID format.
- Updated resource types in multiple YAML files for consistency
- Modified KQL queries to support the new resource type changes
- Adjusted documentation settings and removed deprecated recommendation blocks
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| azure-resources/Web/sites/recommendations.yaml | Updated description and added a recommendation block for Web Site Slots |
| azure-resources/Web/sites/kql/a1d91661-32d4-430b-b3b6-5adeb0975df7.kql | Modified query logic with join conditions and summarization updates |
| azure-resources/Web/sites/kql/0b80b67c-afbe-4988-ad58-a85a146b681e.kql | Updated the AppSettings evaluation logic and query structure |
| azure-resources/Web/sites/kql/0a535241-8dc4-4058-af03-f2fff0abad2a.kql | Added new query for App Service Slot configuration checking |
| azure-resources/Subscription/subscriptions/kql/98bd7098-49d6-491b-86f1-b143d6b1a0ff.kql | Replaced the detailed query with a placeholder comment for under-development status |
| azure-resources/Sql/servers/recommendations.yaml | Changed SQL server resource type to target SQL databases |
| azure-resources/RecoveryServices/vaults/recommendations.yaml | Altered resource type from RecoveryServices vaults to a different resource type |
| azure-resources/Network/networkWatchers/recommendations.yaml | Updated resource type to specify flowlogs |
| azure-resources/Network/frontDoorWebApplicationFirewallPolicies/recommendations.yaml | Removed an existing WAF recommendation block |
| azure-resources/Network/frontDoorWebApplicationFirewallPolicies/_index.md | Updated documentation configuration to hide the section |
| azure-resources/NetApp/netAppAccounts/recommendations.yaml | Changed NetApp resource types to target capacity pools/volumes |
| azure-resources/Compute/galleries/recommendations.yaml | Updated resource type to specify galleries images/versions |
| azure-resources/Cdn/profiles/recommendations.yaml | Updated resource type to originGroups and added a new WAF recommendation block |
Comments suppressed due to low confidence (2)
azure-resources/RecoveryServices/vaults/recommendations.yaml:23
- The resource type for RecoveryServices vaults is changed to Microsoft.Compute/virtualMachines, which seems inconsistent with the file context; please verify if this was intended or if it should remain under RecoveryServices.
recommendationResourceType: Microsoft.Compute/virtualMachines
azure-resources/Cdn/profiles/recommendations.yaml:261
- The new WAF recommendation block uses 'Microsoft.Cdn/profiles' even though the description focuses on Web Application Firewall monitoring; please review whether the resource type should be updated to better reflect the intended target.
recommendationResourceType: Microsoft.Cdn/profiles
kpoineal
changed the title
microsoft-github-policy-service
Bot
added
the
Enhancement 🆕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR updates the resource types in the recommendations YAML files to align with the resource type of the resource ID.
Related Issues/Work Items
AB#40006
Breaking Changes
None.
As part of this pull request I have
mainbranch